hash: use encoding/binary for conversions #55068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ErikPelli wants to merge 1 commit into golang:master from ErikPelli:hash-encoding-binary

Contributor

ErikPelli commented Sep 14, 2022 •

edited

Loading

Use the big endian and little endian conversion functions of the encoding/binary package, instead of a custom implementation in the current package, the behaviour is the same.


          hash: use binary/encoding for conversions

13a1708

Use the big endian and little endian conversion functions of the binary/encoding package, instead of a custom implementation in the current package, the behaviour is the same.

Contributor

gopherbot commented Sep 14, 2022

This PR (HEAD: 13a1708) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/430895 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Sep 14, 2022

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 14, 2022

Message from Erik Pellizzon:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 15, 2022

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 15, 2022

Message from Erik Pellizzon:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430895.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 15, 2022

Message from Zeke Lu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430895.
After addressing review feedback, remember to publish your drafts!

ErikPelli changed the title ~~hash: use binary/encoding for conversions~~ hash: use encoding/binary for conversions

ErikPelli mentioned this pull request

proposal: hash: permit usage of encoding/binary package #55104

Closed

seankhliao closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet