os/signal: TestNohup is flaky

[alberts]

This happens with go test -v -short -cpu 1,2,4,8,16,256 std:

--- FAIL: TestNohup-4 (0.07 seconds)
signal_test.go:186: ran test with -send_uncaught_sighup=1 and it succeeded: expected
failure.
Output:
PASS

go version devel +cfc3bd387c6a Mon May 20 13:27:53 2013 -0700 linux/amd64

[alberts]

Comment 1:

Another one in this package.
This was reported before as issue #4987.
This test doesn't play well with multiple cpu values. This might be the only test in the
standard library that has problems with this, so I think it's worth fixing.
go test -v -cpu 1,2,4 -timeout=60m std
=== RUN TestSignal
--- PASS: TestSignal (0.00 seconds)
signal_test.go:39: sighup...
signal_test.go:48: sigwinch...
signal_test.go:56: sigwinch...
signal_test.go:59: sigwinch...
=== RUN TestStress
--- PASS: TestStress (3.01 seconds)
=== RUN TestStop
--- PASS: TestStop (0.06 seconds)
=== RUN TestNohup
--- PASS: TestNohup (0.24 seconds)
=== RUN TestSignal-2
--- PASS: TestSignal-2 (0.00 seconds)
signal_test.go:39: sighup...
signal_test.go:48: sigwinch...
signal_test.go:56: sigwinch...
signal_test.go:59: sigwinch...
=== RUN TestStress-2
--- PASS: TestStress-2 (3.01 seconds)
=== RUN TestStop-2
--- PASS: TestStop-2 (0.06 seconds)
=== RUN TestNohup-2
--- PASS: TestNohup-2 (0.24 seconds)
=== RUN TestSignal-4
--- FAIL: TestSignal-4 (0.00 seconds)
signal_test.go:39: sighup...
signal_test.go:48: sigwinch...
signal_test.go:25: signal was child exited, want window changed

[alberts]

Comment 2:

Another one in this package.
This was reported before as issue #4987.
This test doesn't play well with multiple cpu values. This might be the only test in the
standard library that has problems with this, so I think it's worth fixing.
go test -v -cpu 1,2,4 -timeout=60m std
=== RUN TestSignal
--- PASS: TestSignal (0.00 seconds)
signal_test.go:39: sighup...
signal_test.go:48: sigwinch...
signal_test.go:56: sigwinch...
signal_test.go:59: sigwinch...
=== RUN TestStress
--- PASS: TestStress (3.01 seconds)
=== RUN TestStop
--- PASS: TestStop (0.06 seconds)
=== RUN TestNohup
--- PASS: TestNohup (0.24 seconds)
=== RUN TestSignal-2
--- PASS: TestSignal-2 (0.00 seconds)
signal_test.go:39: sighup...
signal_test.go:48: sigwinch...
signal_test.go:56: sigwinch...
signal_test.go:59: sigwinch...
=== RUN TestStress-2
--- PASS: TestStress-2 (3.01 seconds)
=== RUN TestStop-2
--- PASS: TestStop-2 (0.06 seconds)
=== RUN TestNohup-2
--- PASS: TestNohup-2 (0.24 seconds)
=== RUN TestSignal-4
--- FAIL: TestSignal-4 (0.00 seconds)
signal_test.go:39: sighup...
signal_test.go:48: sigwinch...
signal_test.go:25: signal was child exited, want window changed

[dsymonds]

Comment 3:

Russ loves signals.

Labels changed: added priority-later, removed priority-triage.

Owner changed to @rsc.

[rsc]

Comment 4:

Labels changed: added go1.2.

Status changed to Accepted.

[rsc]

Comment 5:

Labels changed: added testing.

[rsc]

Comment 6:

Labels changed: added go1.2maybe, removed go1.2.

[rsc]

Comment 7:

Labels changed: added go1.3, removed go1.2maybe.

[rsc]

Comment 8:

Labels changed: added release-go1.3.

[rsc]

Comment 9:

Labels changed: removed go1.3.

[rsc]

Comment 10:

Labels changed: added repo-main.

[davecheney]

Comment 11:

I can not reproduce this issue anymore
% go version
go version devel +eeb3547ccd1b Tue Feb 04 11:53:13 2014 -0800 linux/amd64
I am sure that from time to time we will have tests that do not pass with -cpu set,
mainly because CI does not test this configuration.

Status changed to Fixed.