all: openbsd/ppc64 port #56001

4a6f656c · 2022-10-02T16:51:18Z

This issue is intended to be both a proposal and tracking issue for an openbsd/ppc64 port of Go.

This Go port already exists and is fully functional.

We have a machine available that can run a builder for this port, along with a volunteer who is willing to run it.

Per #55998 @qbit is willing to be an additional maintainer of all OpenBSD Go ports, including this one.

/cc @qbit @golang/ppc64

n2vi · 2022-10-02T17:17:31Z

I confirm that I have a TalosII server allocated for this and will be following the process for adding it to the Builder Dashboard.

laboger · 2022-10-03T13:48:04Z

Power8 is the minimum level supported by the Go ppc64 assembler, for your awareness.

laboger · 2022-10-04T20:37:15Z

If you have the port working, and this is ppc64 (big endian), does it use ELF v1 or v2?

n2vi · 2022-10-04T22:03:35Z

This is all Joel's work, but I'll try to answer to save him time:
Yes, the port is for POWER9 big-endian and (as far as I know) follows the 64-Bit ELF V2 ABI Specification.

ianlancetaylor · 2022-10-05T19:12:54Z

CC @golang/runtime @golang/release

gopherbot · 2022-10-07T03:14:38Z

Change https://go.dev/cl/439978 mentions this issue: unix: add support for openbsd/ppc64

gopherbot · 2022-10-07T03:14:39Z

Change https://go.dev/cl/439977 mentions this issue: cpu: add support for ppc64 on platforms other than aix and linux

This allows the cpu package to function on openbsd/ppc64. Updates golang/go#56001 Change-Id: Iff306b6091da8f7dc28dd1bd2c9ba668b5318a67 Reviewed-on: https://go-review.googlesource.com/c/sys/+/439977 Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]>

Updates golang/go#56001 Change-Id: Ic2c7db7a0c2056d3bbc153066c187f27508cb96c Reviewed-on: https://go-review.googlesource.com/c/sys/+/439978 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Tobias Klauser <[email protected]>

rsc · 2022-10-12T17:53:02Z

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

gopherbot · 2022-10-13T12:18:39Z

Change https://go.dev/cl/442757 mentions this issue: internal/socket: add support for openbsd/ppc64

gopherbot · 2022-10-13T12:18:41Z

Change https://go.dev/cl/442755 mentions this issue: all: update golang.org/x/sys

Update golang.org/x/sys to v0.0.0-20221010170243-090e33056c14. This brings in support for openbsd/ppc64 and openbsd/riscv64. Updates golang/go#55999 Updates golang/go#56001 Change-Id: Iee13561cb1a40ef97946047c10c4eee466f34821 Reviewed-on: https://go-review.googlesource.com/c/net/+/442755 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: David Chase <[email protected]> Run-TryBot: Joel Sing <[email protected]>

Updates golang/go#56001 Change-Id: I9c9b826d09f4f15a144141f64b4b6d5d287721fd Reviewed-on: https://go-review.googlesource.com/c/net/+/442757 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>

rsc · 2022-10-20T17:38:07Z

Sounds like we have two maintainers: @4a6f656c and @qbit.
We also already have openbsd and ppc64 ports separately, so the combination shouldn't add too much.

@golang/runtime, @golang/release, any objections to accepting this proposal (and this port)?

heschi · 2022-10-25T18:35:53Z

No objections from the release team.

prattmic · 2022-10-25T18:41:44Z

No objections from the runtime team.

rsc · 2022-10-26T18:05:03Z

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

rsc · 2022-11-02T18:01:13Z

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

gopherbot · 2023-08-10T15:00:01Z

Change https://go.dev/cl/518275 mentions this issue: cmd/go/testdata/mod: add golang toolchain test data for openbsd/ppc64

On some platforms asmcgocall can be called with a nil g. Additionally, it can be called when already on a the system (g0) stack or on a signal stack. In these cases we do not need to switch (and/or cannot switch) to the system stack and as a result, do not need to save the g. Rework asmcgocall on ppc64x to follow the pattern used on other architectures, such as amd64 and arm64, where a separate nosave path is called in the above cases. The nil g case will be needed to support openbsd/ppc64. Updates #56001 Change-Id: I431d4200bcbc4aaddeb617aefe18590165ff2927 Reviewed-on: https://go-review.googlesource.com/c/go/+/478775 Reviewed-by: Lynn Boger <[email protected]> Reviewed-by: Paul Murphy <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

Add runtime support for the openbsd/ppc64 port. Updates #56001 Change-Id: I3cf010b34f96ce269858b02f16481fdad2cd5b77 Reviewed-on: https://go-review.googlesource.com/c/go/+/475618 Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Paul Murphy <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Lynn Boger <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Eric Grosse <[email protected]>

Add syscall support for the openbsd/ppc64 port. Updates #56001 Change-Id: I695c5c296e90645515de0c8f89f1bc57e976679d Reviewed-on: https://go-review.googlesource.com/c/go/+/475636 Reviewed-by: Eric Grosse <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

Add linker support for the openbsd/ppc64 port. Updates #56001 Change-Id: I18bc19b4086599996aebfbe68f2e85e1200589ca Reviewed-on: https://go-review.googlesource.com/c/go/+/475619 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Lynn Boger <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Paul Murphy <[email protected]> Reviewed-by: Eric Grosse <[email protected]>

Updates #56001 Change-Id: Ic7b4ecb2e471292894c54610e8acda8822c890fb Reviewed-on: https://go-review.googlesource.com/c/go/+/518275 Reviewed-by: Matthew Dempsky <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Paul Murphy <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

On some platforms asmcgocall can be called with a nil g. Additionally, it can be called when already on a the system (g0) stack or on a signal stack. In these cases we do not need to switch (and/or cannot switch) to the system stack and as a result, do not need to save the g. Rework asmcgocall on ppc64x to follow the pattern used on other architectures, such as amd64 and arm64, where a separate nosave path is called in the above cases. The nil g case will be needed to support openbsd/ppc64. Updates golang#56001 Change-Id: I431d4200bcbc4aaddeb617aefe18590165ff2927 Reviewed-on: https://go-review.googlesource.com/c/go/+/478775 Reviewed-by: Lynn Boger <[email protected]> Reviewed-by: Paul Murphy <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

Add runtime support for the openbsd/ppc64 port. Updates golang#56001 Change-Id: I3cf010b34f96ce269858b02f16481fdad2cd5b77 Reviewed-on: https://go-review.googlesource.com/c/go/+/475618 Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Paul Murphy <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Lynn Boger <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Eric Grosse <[email protected]>

Add syscall support for the openbsd/ppc64 port. Updates golang#56001 Change-Id: I695c5c296e90645515de0c8f89f1bc57e976679d Reviewed-on: https://go-review.googlesource.com/c/go/+/475636 Reviewed-by: Eric Grosse <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

Add linker support for the openbsd/ppc64 port. Updates golang#56001 Change-Id: I18bc19b4086599996aebfbe68f2e85e1200589ca Reviewed-on: https://go-review.googlesource.com/c/go/+/475619 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Lynn Boger <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Paul Murphy <[email protected]> Reviewed-by: Eric Grosse <[email protected]>

Updates golang#56001 Change-Id: Ic7b4ecb2e471292894c54610e8acda8822c890fb Reviewed-on: https://go-review.googlesource.com/c/go/+/518275 Reviewed-by: Matthew Dempsky <[email protected]> Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Paul Murphy <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

Updates #56001 Change-Id: I16440114ecf661e9fc17d304ab3b16bc97ef82f8 Reviewed-on: https://go-review.googlesource.com/c/go/+/517935 Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Paul Murphy <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>

gopherbot · 2023-12-06T17:01:46Z

Change https://go.dev/cl/547935 mentions this issue: internal/releasetargets: regenerate all ports for Go 1.22

cherrymui · 2023-12-06T17:30:57Z

@4a6f656c @qbit would you like to write release notes for the new port? Thanks.

gopherbot · 2023-12-07T16:36:31Z

Change https://go.dev/cl/547999 mentions this issue: doc/go1.22: document openbsd/ppc64 port

Updates #56001. For #61422. Change-Id: Ie4afbc42191b155d28945bd8f104ad7a63d30db9 Reviewed-on: https://go-review.googlesource.com/c/go/+/547999 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]>

It's the same list as 1.21, with the addition of the openbsd/ppc64 port. Generated with 'go generate'. For golang/go#40561. For golang/go#56001. Change-Id: I93d2cfd191134f524255393e8b60bf6ce7328940 Reviewed-on: https://go-review.googlesource.com/c/build/+/547935 Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>

cherrymui · 2023-12-08T21:04:41Z

Is the port done, or there are still things to do? Can we close this issue? Thanks.

dmitshur · 2023-12-08T21:55:45Z

It shows up in the port list (gotip tool dist list) as of CL 517935,
it's documented in the release notes (CL 547999),
and the builder at build.golang.org is passing (there's more work to add it to LUCI; that's #63480).
It still has its known issue set to this one, and that should be removed. I sent CL 548218 to do that.
If there's more to do, it's okay to track in separate issues.

Thanks and congratulations!

gopherbot · 2023-12-08T21:56:04Z

Change https://go.dev/cl/548218 mentions this issue: dashboard: remove known issue for openbsd-ppc64-n2vi

Updates golang#56001. For golang#61422. Change-Id: Ie4afbc42191b155d28945bd8f104ad7a63d30db9 Reviewed-on: https://go-review.googlesource.com/c/go/+/547999 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]>

gopherbot · 2024-05-13T17:01:25Z

Change https://go.dev/cl/585216 mentions this issue: internal/releasetargets: add openbsd/ppc64 target for Go 1.22 onwards

The release target list has two underlying sources: the allReleases map and the allPorts map. The former is a small curated map, mostly used to indicate which ports are first-class, and to set a few port properties. The latter is generated from 'go tool dist list' output for each major Go release. Unfortunately, the logic in TargetsForGo1Point ended up not taking into account that CL 547935 added allports/go1.22.txt with the openbsd/ppc64 port in it because the allReleases map didn't have an entry for go1.22. As a result, we haven't been making releases for the openbsd/ppc64 port as intended. :( Fix this by making sortedReleases consult both sources. For golang/go#40561. For golang/go#56001. Change-Id: Icbabad6f7e2920c1b24a69e309d65aea77c9c461 Reviewed-on: https://go-review.googlesource.com/c/build/+/585216 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

gopherbot · 2024-05-13T17:37:26Z

Change https://go.dev/cl/585217 mentions this issue: main.star: delete openbsd/ppc64 builders on release-branch.go1.21

The port wasn't added until Go 1.22, so no need to test it with Go 1.21. Also set a timeout scale factor of 2 for now, while the LUCI builder is running alongside the coordinator builder on the same hardware. This is fine to adjust later as it becomes more clear what the optimal value is. For golang/go#63480. For golang/go#56001. Change-Id: I707ffe7d15afa6a70d6d8789f959a5835259df3f Reviewed-on: https://go-review.googlesource.com/c/build/+/585217 Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

4a6f656c added the Proposal label Oct 2, 2022

ianlancetaylor changed the title ~~all: openbsd/ppc64 port~~ proposal: openbsd/ppc64 port Oct 5, 2022

gopherbot added this to the Proposal milestone Oct 5, 2022

ianlancetaylor added this to Proposals Oct 5, 2022

ianlancetaylor moved this to Incoming in Proposals Oct 5, 2022

rsc moved this from Incoming to Active in Proposals Oct 12, 2022

thanm mentioned this issue Oct 25, 2022

Go compiler and runtime meeting notes #43930

Open

rsc moved this from Active to Likely Accept in Proposals Oct 26, 2022

rsc added the Proposal-FinalCommentPeriod label Oct 26, 2022

rsc moved this from Likely Accept to Accepted in Proposals Nov 2, 2022

rsc changed the title ~~proposal: openbsd/ppc64 port~~ openbsd/ppc64 port Nov 2, 2022

4a6f656c mentioned this issue Aug 10, 2023

x/build: builder issues bringing up new ports #61925

Closed

dmitshur modified the milestones: Backlog, Go1.22 Dec 8, 2023

gopherbot closed this as completed in golang/build@106fb71 Dec 11, 2023

aclements removed this from Proposals Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: openbsd/ppc64 port #56001

all: openbsd/ppc64 port #56001

4a6f656c commented Oct 2, 2022

n2vi commented Oct 2, 2022

laboger commented Oct 3, 2022

laboger commented Oct 4, 2022

n2vi commented Oct 4, 2022

ianlancetaylor commented Oct 5, 2022

gopherbot commented Oct 7, 2022

gopherbot commented Oct 7, 2022

rsc commented Oct 12, 2022

gopherbot commented Oct 13, 2022

gopherbot commented Oct 13, 2022

rsc commented Oct 20, 2022 •

edited by aclements

Loading

heschi commented Oct 25, 2022

prattmic commented Oct 25, 2022

rsc commented Oct 26, 2022

rsc commented Nov 2, 2022

gopherbot commented Aug 10, 2023

gopherbot commented Dec 6, 2023

cherrymui commented Dec 6, 2023

gopherbot commented Dec 7, 2023

cherrymui commented Dec 8, 2023

dmitshur commented Dec 8, 2023

gopherbot commented Dec 8, 2023

gopherbot commented May 13, 2024

gopherbot commented May 13, 2024

all: openbsd/ppc64 port #56001

all: openbsd/ppc64 port #56001

Comments

4a6f656c commented Oct 2, 2022

n2vi commented Oct 2, 2022

laboger commented Oct 3, 2022

laboger commented Oct 4, 2022

n2vi commented Oct 4, 2022

ianlancetaylor commented Oct 5, 2022

gopherbot commented Oct 7, 2022

gopherbot commented Oct 7, 2022

rsc commented Oct 12, 2022

gopherbot commented Oct 13, 2022

gopherbot commented Oct 13, 2022

rsc commented Oct 20, 2022 • edited by aclements Loading

heschi commented Oct 25, 2022

prattmic commented Oct 25, 2022

rsc commented Oct 26, 2022

rsc commented Nov 2, 2022

gopherbot commented Aug 10, 2023

gopherbot commented Dec 6, 2023

cherrymui commented Dec 6, 2023

gopherbot commented Dec 7, 2023

cherrymui commented Dec 8, 2023

dmitshur commented Dec 8, 2023

gopherbot commented Dec 8, 2023

gopherbot commented May 13, 2024

gopherbot commented May 13, 2024

rsc commented Oct 20, 2022 •

edited by aclements

Loading