Skip to content

cmd/compile: libFuzzer instrumentation fakePC overflow on 386 arch [1.19 backport] #56168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Oct 12, 2022 · 2 comments
Closed

cmd/compile: libFuzzer instrumentation fakePC overflow on 386 arch [1.19 backport] #56168

gopherbot opened this issue Oct 12, 2022 · 2 comments
Assignees
@cuonglm
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.3

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #56141 to be considered for backport to the next 1.19 minor release.

@gopherbot please open a backport to 1.19. This bug causes libfuzzer mode to fail to compile. There is no easy workaround.
(I don't think this applies to 1.18.)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 12, 2022
@gopherbot gopherbot mentioned this issue Oct 12, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 12, 2022
@gopherbot gopherbot added this to the Go1.19.3 milestone Oct 12, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/442435 mentions this issue: [release-branch.go1.19] all: prevent fakePC overflow on 386 in libfuzzer mode

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Oct 12, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 12, 2022
@mknyszek mknyszek moved this to All-But-Submitted in Go Compiler / Runtime Oct 12, 2022
gopherbot pushed a commit that referenced this issue Oct 24, 2022
@cuonglm @heschi
[release-branch.go1.19] all: prevent fakePC overflow on 386 in libfuz…
e73130c 
…zer mode

fakePC uses hash.Sum32, which returns an uint32. However, libfuzzer
trace/hook functions declare fakePC argument as int, causing overflow on
386 archs.

Fixing this by changing fakePC argument to uint to prevent the overflow.

Fixes #56168

Change-Id: I3994c461319983ab70065f90bf61539a363e0a2a
Reviewed-on: https://go-review.googlesource.com/c/go/+/441996
Auto-Submit: Cuong Manh Le <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Run-TryBot: Cuong Manh Le <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/442435
Reviewed-by: David Chase <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging e73130c to release-branch.go1.19.

Repository owner moved this from All-But-Submitted to Done in Go Compiler / Runtime Oct 24, 2022
andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@cuonglm @andrew-d
[release-branch.go1.19] all: prevent fakePC overflow on 386 in libfuz…
5bc4011 
…zer mode

fakePC uses hash.Sum32, which returns an uint32. However, libfuzzer
trace/hook functions declare fakePC argument as int, causing overflow on
386 archs.

Fixing this by changing fakePC argument to uint to prevent the overflow.

Fixes golang#56168

Change-Id: I3994c461319983ab70065f90bf61539a363e0a2a
Reviewed-on: https://go-review.googlesource.com/c/go/+/441996
Auto-Submit: Cuong Manh Le <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Run-TryBot: Cuong Manh Le <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/442435
Reviewed-by: David Chase <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
@golang golang locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuonglm cuonglm

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.3
Development

No branches or pull requests
3 participants
@cuonglm @gopherbot @joedian