-
Notifications
You must be signed in to change notification settings - Fork 18k
x/tools/gopls/internal/regtest/codelens: TestUpgradeCodelens failures #58750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Found new dashboard test flakes for:
2023-02-25 00:08 linux-s390x-ibm tools@f98fce20 go@af6bb3f9 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Closing this as it appears to be transient problems with the s390x builder. |
Found new dashboard test flakes for:
2023-06-16 16:38 linux-s390x-ibm tools@a4ed05f1 go@9ece9a7a x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
I suspect this may have been a hanging go command, but we unfortunately didn't get a stack. |
Found new dashboard test flakes for:
2023-08-07 19:27 linux-s390x-ibm tools@f42bca8e go@008ab9ad x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Don't know why, but I've hit this twice in TryBots recently. Seems like a regression? |
linux-arm64 failure: |
Found new dashboard test flakes for:
2023-08-10 21:06 linux-amd64-nocgo tools@6b4d1de1 go@61719e18 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-10 21:06 linux-ppc64-sid-power10 tools@6b4d1de1 go@673d64ac x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-10 21:06 linux-s390x-ibm tools@6b4d1de1 go@201f8b40 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-11 23:12 linux-amd64-alpine tools@6290d8a9 go@ac64a362 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-14 16:17 linux-arm64 tools@fa12f34b go@41c71d48 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-15 13:25 linux-arm64-boringcrypto tools@74c255bc go@94d36fbc x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-15 14:21 linux-386-clang tools@64e92489 go@9c93ad55 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-15 14:21 linux-amd64-goamd64v3 tools@64e92489 go@fc212a93 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-15 14:21 linux-amd64-longtest tools@64e92489 go@16ec27b4 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-15 14:21 linux-amd64-longtest tools@64e92489 go@3be2176d x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-16 19:26 linux-arm64-longtest tools@b225aa05 go@2fcfdb96 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 19:26 linux-arm64-longtest tools@b225aa05 go@5fa4aac0 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 19:26 linux-ppc64-sid-power10 tools@b225aa05 go@5fa4aac0 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 19:26 linux-ppc64-sid-power10 tools@b225aa05 go@b78e8cc1 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-15 14:21 linux-arm64-boringcrypto tools@64e92489 go@fc212a93 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-15 14:21 linux-arm64-longtest tools@64e92489 go@16ec27b4 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-15 14:21 linux-ppc64-sid-power10 tools@64e92489 go@9c93ad55 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 12:01 linux-ppc64le-power10osu tools@a80931dd go@3475e6af x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 16:17 linux-amd64-nocgo tools@0286c389 go@f6360cf4 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 16:17 linux-arm64-longtest tools@0286c389 go@9f03e836 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 16:17 linux-arm64-longtest tools@0286c389 go@5b8ceb38 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 16:17 linux-arm64-longtest tools@0286c389 go@9cf209f6 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 19:26 linux-amd64-goamd64v3 tools@b225aa05 go@1c003540 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 19:26 linux-arm64 tools@b225aa05 go@99b80993 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-16 19:26 linux-amd64-nocgo tools@b225aa05 go@48e05ee7 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 19:26 linux-arm64-boringcrypto tools@b225aa05 go@2fcfdb96 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-16 19:26 linux-arm64-longtest tools@b225aa05 go@aaa384cf x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-16 19:26 linux-arm64-boringcrypto tools@b225aa05 go@b75ac7a8 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-16 19:26 linux-ppc64le-power10osu tools@b225aa05 go@b75ac7a8 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-16 19:26 linux-amd64-sid tools@b225aa05 go@14e3c733 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-16 19:26 linux-amd64-clang tools@b225aa05 go@bcf83825 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-18 13:05 linux-386-sid tools@1517d1a3 go@d63c88d6 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-18 14:18 linux-amd64-boringcrypto tools@9425c2e7 go@b65e34f0 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-18 14:18 linux-386-longtest tools@9425c2e7 go@e8a767b6 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-18 14:18 linux-ppc64-sid-power10 tools@9425c2e7 go@8789b5d7 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-18 14:18 linux-amd64-longtest tools@9425c2e7 go@e8cdab5c x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-18 14:18 linux-ppc64-sid-power10 tools@9425c2e7 go@69285cd7 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-18 14:18 linux-s390x-ibm tools@9425c2e7 go@b4636682 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-18 14:18 linux-386-clang tools@9425c2e7 go@e094e80f x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-21 13:22 linux-amd64-sid tools@ff7f2b9c go@70aa116c x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-21 18:01 linux-amd64-goamd64v3 tools@c38e6b06 go@70aa116c x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-21 18:01 linux-s390x-ibm tools@c38e6b06 go@70aa116c x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-21 18:01 linux-arm64-longtest tools@c38e6b06 go@1081f8c0 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-21 20:35 linux-amd64-alpine tools@6eca6dfb go@b4636682 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-21 20:35 linux-amd64-longtest tools@6eca6dfb go@47645420 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-21 20:35 linux-amd64-goamd64v3 tools@6eca6dfb go@fecf5171 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-21 20:35 linux-amd64-alpine tools@6eca6dfb go@05f95115 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Change https://go.dev/cl/521895 mentions this issue: |
Found new dashboard test flakes for:
2023-08-21 20:35 linux-amd64-bullseye tools@6eca6dfb go@47112996 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
2023-08-21 20:35 linux-amd64-nocgo tools@6eca6dfb go@47112996 x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-08-21 20:35 linux-arm64-longtest tools@6eca6dfb go@70a8a41e x/tools/gopls/internal/regtest/codelens.TestUpgradeCodelens (log)
|
Avoid (but do not fix) a race in TestUpgradeCodelens: because upgrade and vuln diagnostics access state on the View, they race with asynchronous diagnostics, which assume that diagnostics are idempotent. Diagnostics _should_ be idempotent: we should create a new snapshot when the view state changes (and inject that state into the snapshot). But that is a larger change, and this CL will confirm the hypothesis above if the flakes go away. For golang/go#58750 Change-Id: If827aab0ae187c5c377d830d76caf626b51bc3bc Reviewed-on: https://go-review.googlesource.com/c/tools/+/521895 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Robert Findley <[email protected]> gopls-CI: kokoro <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Change https://go.dev/cl/540479 mentions this issue: |
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: