Skip to content

time: time zone lookup using extend string makes wrong start time for non-DST zones [1.20 backport] #59075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 16, 2023 · 2 comments
Closed

time: time zone lookup using extend string makes wrong start time for non-DST zones [1.20 backport] #59075

gopherbot opened this issue Mar 16, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.3

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #58682 to be considered for backport to the next 1.20 minor release.

@gopherbot Please open backport issues

We incorrectly handle the timezone bounds for timezones that used to have daylight savings time and then stopped.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 16, 2023
@gopherbot gopherbot mentioned this issue Mar 16, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.3 milestone Mar 16, 2023
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Mar 22, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 22, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/478658 mentions this issue: [release-branch.go1.20] time: fix timezone lookup logic for non-DST zones

gopherbot pushed a commit that referenced this issue Mar 23, 2023
@KimMachineGun @gopherbot
[release-branch.go1.20] time: fix timezone lookup logic for non-DST z…
65fa8a6 
…ones

This change fixes time.LoadLocationFromTZData and time.Location.lookup logic if the given time is after the last transition and the extend string doesn't have the DST rule.

For #58682
Fixes #59075

Change-Id: Ie34a6d658d14c2b33098b29ab83c041ef0d34266
GitHub-Last-Rev: f6681eb
GitHub-Pull-Request: #58684
Reviewed-on: https://go-review.googlesource.com/c/go/+/471020
Reviewed-by: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
(cherry picked from commit 90dde5d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/478658
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Auto-Submit: Heschi Kreinick <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 65fa8a6 to release-branch.go1.20.

@golang golang locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.3
Development

No branches or pull requests
2 participants
@gopherbot @heschi