Skip to content

runtime: TestCgoTraceParser failures #59233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 24, 2023 · 13 comments
Closed

runtime: TestCgoTraceParser failures #59233

gopherbot opened this issue Mar 24, 2023 · 13 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Mar 24, 2023 •
edited by mknyszek
Loading 

#!watchflakes
post <- pkg == "runtime" && (test == "TestCgoTraceParser" || test == "TestCgoTraceParserWithOneProc")

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestCgoTraceParser (0.08s)
    crash_cgo_test.go:737: /var/gobuilder/buildlet/tmp/go-build3741504798/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:743: want OK
        , got panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 24, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestCgoTraceParser"
2023-03-24 16:00 netbsd-arm-bsiegert go@ef0dedce runtime.TestCgoTraceParser (log) 
--- FAIL: TestCgoTraceParser (0.08s)
    crash_cgo_test.go:737: /var/gobuilder/buildlet/tmp/go-build3741504798/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:743: want OK
        , got panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 24, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestCgoTraceParser"
2023-03-24 18:14 netbsd-arm-bsiegert go@2716dfd9 runtime.TestCgoTraceParser (log) 
--- FAIL: TestCgoTraceParser (0.07s)
    crash_cgo_test.go:737: /var/gobuilder/buildlet/tmp/go-build1118342320/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:743: want OK
        , got panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestCgoTraceParser"
2023-03-24 17:48 netbsd-arm-bsiegert go@59d7c693 runtime.TestCgoTraceParser (log) 
--- FAIL: TestCgoTraceParser (0.08s)
    crash_cgo_test.go:737: /var/gobuilder/buildlet/tmp/go-build632147128/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:743: want OK
        , got panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]

— watchflakes

@mknyszek
Copy link
Contributor

In triage @prattmic thinks that it's builder specific. This machine is the only one failing, suggesting that something got updated and libc is doing something unexpected (from our perspective).

CC @bsiegert

@mknyszek mknyszek mentioned this issue Mar 29, 2023
Closed
@prattmic
Copy link
Member

Actually, it looks like this was a continuous failure from https://go.dev/cl/392854 and fixed by https://go.dev/cl/479255.

@github-project-automation github-project-automation bot moved this from Todo to Done in Go Compiler / Runtime Mar 29, 2023
@gopherbot gopherbot reopened this Mar 30, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && (test == "TestCgoTraceParser" || test == "TestCgoTraceParserWithOneProc")
2023-03-30 19:18 dragonfly-amd64-622 go@ba718173 runtime.TestCgoTraceParser (log) 
--- FAIL: TestCgoTraceParser (0.07s)
    crash_cgo_test.go:743: /tmp/workdir/tmp/go-build76392673/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:749: want OK
        , got SIGSEGV: segmentation violation
        PC=0x457ca3 m=1 sigcode=1

        rax    0xc000006680
        rbx    0x828280018
        rcx    0x7
        rdx    0x2
        rdi    0x80
        rsi    0x8
        rbp    0x7fdfe0c06d68
        rsp    0x7fdfe0c06d38
        r8     0x828280028
        r9     0x7e
        r10    0x8008a7a11
        r11    0xbb
        r12    0xba
        r13    0xc00004e000
        r14    0xc0000064e0
        r15    0xe
        rip    0x457ca3
        rflags 0x10202
        cs     0x2b
        fs     0x23
        gs     0x23
2023-03-30 19:18 dragonfly-amd64-622 go@ba718173 runtime.TestCgoTraceParserWithOneProc (log) 
--- FAIL: TestCgoTraceParserWithOneProc (0.16s)
    crash_cgo_test.go:759: /tmp/workdir/tmp/go-build76392673/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:765: GOMAXPROCS=1, want OK
        , got SIGSEGV: segmentation violation
        PC=0x457ca3 m=1 sigcode=1

        rax    0xc000006680
        rbx    0x800fd4018
        rcx    0x7
        rdx    0x2
        rdi    0x80
        rsi    0x6
        rbp    0x7fdfe0804d68
        rsp    0x7fdfe0804d38
        r8     0x800fd4028
        r9     0x7e
        r10    0x8008a7a11
        r11    0xc4
        r12    0xc3
        r13    0xc00003e000
        r14    0xc0000064e0
        r15    0x20
        rip    0x457ca3
        rflags 0x10206
        cs     0x2b
        fs     0x23
        gs     0x23
2023-03-30 19:18 netbsd-amd64-9_3 go@ba718173 runtime.TestCgoTraceParser (log) 
--- FAIL: TestCgoTraceParser (0.04s)
    crash_cgo_test.go:743: /tmp/workdir/tmp/go-build4034945063/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:749: want OK
        , got SIGSEGV: segmentation violation
        PC=0x459c03 m=1 sigcode=1

        rax    0xc000006680
        rbx    0x76da86bf0018
        rcx    0x7
        rdx    0x2
        rdi    0x80
        rsi    0x40
        rbp    0x76da5d5dfd78
        rsp    0x76da5d5dfd48
        r8     0x76da86bf0028
        r9     0x7e
        r10    0x76da8700c762
        r11    0x35
        r12    0x34
        r13    0xc00004e000
        r14    0xc0000064e0
        r15    0x2
        rip    0x459c03
        rflags 0x10202
        cs     0x47
        fs     0x0
        gs     0x0
2023-03-30 19:18 netbsd-amd64-9_3 go@ba718173 runtime.TestCgoTraceParserWithOneProc (log) 
--- FAIL: TestCgoTraceParserWithOneProc (0.08s)
    crash_cgo_test.go:759: /tmp/workdir/tmp/go-build4034945063/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:765: GOMAXPROCS=1, want OK
        , got SIGSEGV: segmentation violation
        PC=0x459c03 m=1 sigcode=1

        rax    0xc000006680
        rbx    0x7352ac4b0018
        rcx    0x7
        rdx    0x2
        rdi    0x80
        rsi    0x40
        rbp    0x73528365ad78
        rsp    0x73528365ad48
        r8     0x7352ac4b0028
        r9     0x7e
        r10    0x7352ac60c762
        r11    0xc5
        r12    0xc4
        r13    0xc00003e000
        r14    0xc0000064e0
        r15    0x21
        rip    0x459c03
        rflags 0x10202
        cs     0x47
        fs     0x0
        gs     0x0

— watchflakes

@github-project-automation github-project-automation bot moved this from Done to In Progress in Go Compiler / Runtime Mar 30, 2023
@prattmic
Copy link
Member

cc @felixge

Looks like tests broken by https://go.dev/cl/463835 and fixed by https://go.dev/cl/474916

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Mar 30, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && (test == "TestCgoTraceParser" || test == "TestCgoTraceParserWithOneProc")
2023-03-31 19:15 linux-arm-aws go@99276aeb runtime.TestCgoTraceParser (log) 
--- FAIL: TestCgoTraceParser (0.00s)
    crash_cgo_test.go:743: /workdir/tmp/go-build590000508/testprogcgo.exe CgoTraceParser: signal: segmentation fault (core dumped)
    crash_cgo_test.go:749: want OK
        , got

— watchflakes

@gopherbot gopherbot reopened this Mar 31, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Go Compiler / Runtime Mar 31, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && (test == "TestCgoTraceParser" || test == "TestCgoTraceParserWithOneProc")
2023-03-31 19:15 netbsd-arm-bsiegert go@99276aeb runtime.TestCgoTraceParser (log) 
--- FAIL: TestCgoTraceParser (0.08s)
    crash_cgo_test.go:743: /var/gobuilder/buildlet/tmp/go-build646227022/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:749: want OK
        , got panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]
2023-03-31 19:15 netbsd-arm-bsiegert go@99276aeb runtime.TestCgoTraceParserWithOneProc (log) 
--- FAIL: TestCgoTraceParserWithOneProc (0.12s)
    crash_cgo_test.go:759: /var/gobuilder/buildlet/tmp/go-build646227022/testprogcgo.exe CgoTraceParser: exit status 2
    crash_cgo_test.go:765: GOMAXPROCS=1, want OK
        , got panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]

— watchflakes

@felixge
Copy link
Contributor

felixge commented Apr 2, 2023

@prattmic I looked into this a little. I suspect these flakes are caused by the ongoing work in #59294 🤔. At least I didn't see any evidence (e.g. stack traces) that the new frame pointer unwinding is involved. Did I miss something?

@bcmills
Copy link
Contributor

bcmills commented Apr 3, 2023

In triage [@]prattmic thinks that it's builder specific. This machine is the only one failing, suggesting that something got updated and libc is doing something unexpected (from our perspective).

The failure in #59233 (comment) is on linux-arm-aws, which is not only a different machine but also a completely different kernel, so probably bsiegert is not the right assignee for this.

@prattmic
Copy link
Member

prattmic commented Apr 3, 2023

I could believe that. So far all failures are between https://go.dev/cl/392854 and its revert https://go.dev/cl/481060.

cc @cherrymui @doujiang24

@cherrymui
Copy link
Member

All these failures were during my sequence of reverting CLs, in particular, between reverting the ARM fix and reverting the original CL.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Apr 3, 2023
@golang golang locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Archived in project
Milestone
No milestone
Development

No branches or pull requests
7 participants
@felixge @bsiegert @mknyszek @prattmic @bcmills @gopherbot @cherrymui