Skip to content

crypto/subtle: xor fails when run with race+purego [1.20 backport] #59336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 30, 2023 · 2 comments
Closed

crypto/subtle: xor fails when run with race+purego [1.20 backport] #59336

gopherbot opened this issue Mar 30, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.4

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #59334 to be considered for backport to the next 1.20 minor release.

@gopherbot please open a backport issue to 1.20. This is a potential crash when running with the race detector.

This code is quite different in 1.19. I don't think it suffers from the same issue.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 30, 2023
@gopherbot gopherbot mentioned this issue Mar 30, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.3 milestone Mar 30, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/481238 mentions this issue: [release-branch.go1.20] crypto/subtle: don't cast to *uintptr when word size is 0

@mknyszek mknyszek modified the milestones: Go1.20.3, Go1.20.4 Apr 4, 2023
@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Apr 5, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 5, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging dcc9bdf to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Apr 5, 2023
@randall77 @gopherbot
[release-branch.go1.20] crypto/subtle: don't cast to *uintptr when wo…
dcc9bdf 
…rd size is 0

Casting to a *uintptr is not ok if there isn't at least 8 bytes of
data backing that pointer (on 64-bit archs).
So although we end up making a slice of 0 length with that pointer,
the cast itself doesn't know that.
Instead, bail early if the result is going to be 0 length.

Fixes #59336

Change-Id: Id3c0e09d341d838835c0382cccfb0f71dc3dc7e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/480575
Run-TryBot: Keith Randall <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
(cherry picked from commit 297cf6dd31bd99fc4ccda320aa3d4faf290ab278)
Reviewed-on: https://go-review.googlesource.com/c/go/+/481238
Reviewed-by: Keith Randall <[email protected]>
Auto-Submit: Michael Knyszek <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@randall77 @bradfitz
[release-branch.go1.20] crypto/subtle: don't cast to *uintptr when wo…
b36d6bd 
…rd size is 0

Casting to a *uintptr is not ok if there isn't at least 8 bytes of
data backing that pointer (on 64-bit archs).
So although we end up making a slice of 0 length with that pointer,
the cast itself doesn't know that.
Instead, bail early if the result is going to be 0 length.

Fixes golang#59336

Change-Id: Id3c0e09d341d838835c0382cccfb0f71dc3dc7e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/480575
Run-TryBot: Keith Randall <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
(cherry picked from commit 297cf6dd31bd99fc4ccda320aa3d4faf290ab278)
Reviewed-on: https://go-review.googlesource.com/c/go/+/481238
Reviewed-by: Keith Randall <[email protected]>
Auto-Submit: Michael Knyszek <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@randall77 @bradfitz
[release-branch.go1.20] crypto/subtle: don't cast to *uintptr when wo…
b376471 
…rd size is 0

Casting to a *uintptr is not ok if there isn't at least 8 bytes of
data backing that pointer (on 64-bit archs).
So although we end up making a slice of 0 length with that pointer,
the cast itself doesn't know that.
Instead, bail early if the result is going to be 0 length.

Fixes golang#59336

Change-Id: Id3c0e09d341d838835c0382cccfb0f71dc3dc7e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/480575
Run-TryBot: Keith Randall <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
(cherry picked from commit 297cf6dd31bd99fc4ccda320aa3d4faf290ab278)
Reviewed-on: https://go-review.googlesource.com/c/go/+/481238
Reviewed-by: Keith Randall <[email protected]>
Auto-Submit: Michael Knyszek <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.4
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot