Skip to content

net/http: FileServer no longer serves content for POST [1.20 backport] #59469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 6, 2023 · 2 comments
Closed

net/http: FileServer no longer serves content for POST [1.20 backport] #59469

gopherbot opened this issue Apr 6, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.4

Comments

@gopherbot
Copy link
Contributor

@rsc requested issue #59375 to be considered for backport to the next 1.20 minor release.

@gopherbot please backport go1.20
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 6, 2023
@gopherbot gopherbot mentioned this issue Apr 6, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.4 milestone Apr 6, 2023
@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Apr 12, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 12, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/488635 mentions this issue: [release-branch.go1.20] Revert "net/http: FileServer method check + minimal OPTIONS implementation"

@gopherbot
Copy link
Contributor Author

Closed by merging 25b4f40 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Apr 25, 2023
@neild @gopherbot
[release-branch.go1.20] Revert "net/http: FileServer method check + m…
25b4f40 
…inimal OPTIONS implementation"

This reverts https://go.dev/cl/413554

Reason for revert: Backwards-incompatible change in behavior.

For #53501
For #59375
Fixes #59469

Change-Id: Ic3f63b378f9c819599b32e5e6e410f6163849317
Reviewed-on: https://go-review.googlesource.com/c/go/+/482635
Reviewed-by: Tatiana Bradley <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit c02fa75)
Reviewed-on: https://go-review.googlesource.com/c/go/+/488635
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@neild @bradfitz
[release-branch.go1.20] Revert "net/http: FileServer method check + m…
53ff1ad 
…inimal OPTIONS implementation"

This reverts https://go.dev/cl/413554

Reason for revert: Backwards-incompatible change in behavior.

For golang#53501
For golang#59375
Fixes golang#59469

Change-Id: Ic3f63b378f9c819599b32e5e6e410f6163849317
Reviewed-on: https://go-review.googlesource.com/c/go/+/482635
Reviewed-by: Tatiana Bradley <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit c02fa75)
Reviewed-on: https://go-review.googlesource.com/c/go/+/488635
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@neild @bradfitz
[release-branch.go1.20] Revert "net/http: FileServer method check + m…
07104bd 
…inimal OPTIONS implementation"

This reverts https://go.dev/cl/413554

Reason for revert: Backwards-incompatible change in behavior.

For golang#53501
For golang#59375
Fixes golang#59469

Change-Id: Ic3f63b378f9c819599b32e5e6e410f6163849317
Reviewed-on: https://go-review.googlesource.com/c/go/+/482635
Reviewed-by: Tatiana Bradley <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit c02fa75)
Reviewed-on: https://go-review.googlesource.com/c/go/+/488635
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.4
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot