Skip to content

net/http: TestTransportRequestWriteRoundTrip failures #59883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gopherbot opened this issue Apr 28, 2023 · 4 comments
Open

net/http: TestTransportRequestWriteRoundTrip failures #59883

gopherbot opened this issue Apr 28, 2023 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Apr 28, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "net/http" && log ~ `WARNING: DATA RACE` && log ~ `net/http_test.testServerExpect`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportRequestWriteRoundTrip (0.00s)
    --- FAIL: TestTransportRequestWriteRoundTrip/h2 (0.36s)
        --- FAIL: TestTransportRequestWriteRoundTrip/h2/buffer,_length_-1 (0.05s)
            testing.go:1465: race detected during execution of test
        testing.go:1465: race detected during execution of test
    --- FAIL: TestTransportRequestWriteRoundTrip/h1 (0.40s)
        --- FAIL: TestTransportRequestWriteRoundTrip/h1/buffer,_length_-1 (0.04s)
            testing.go:1465: race detected during execution of test
        testing.go:1465: race detected during execution of test

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 28, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportRequestWriteRoundTrip"
2023-04-28 01:33 linux-amd64-race go@71ad46cd net/http.TestTransportRequestWriteRoundTrip (log) 
--- FAIL: TestTransportRequestWriteRoundTrip (0.00s)
    --- FAIL: TestTransportRequestWriteRoundTrip/h2 (0.36s)
        --- FAIL: TestTransportRequestWriteRoundTrip/h2/buffer,_length_-1 (0.05s)
            testing.go:1465: race detected during execution of test
        testing.go:1465: race detected during execution of test
    --- FAIL: TestTransportRequestWriteRoundTrip/h1 (0.40s)
        --- FAIL: TestTransportRequestWriteRoundTrip/h1/buffer,_length_-1 (0.04s)
            testing.go:1465: race detected during execution of test
        testing.go:1465: race detected during execution of test

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/490255 mentions this issue: net/http: avoid leaking the writing goroutine

gopherbot pushed a commit that referenced this issue May 2, 2023
@fraenkel @gopherbot
net/http: avoid leaking the writing goroutine
c630661 
The test will wait for all goroutines.
A race can occur if the writing goroutine uses the Log after the test exits.

For #58264
For #59883
For #59884

Change-Id: I9b8ec7c9d024ff74b922b69efa438be5a4fa3483
Reviewed-on: https://go-review.googlesource.com/c/go/+/490255
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportRequestWriteRoundTrip"
2023-05-10 22:55 darwin-amd64-13 go@3d80d57c net/http.TestTransportRequestWriteRoundTrip (log) 
--- FAIL: TestTransportRequestWriteRoundTrip (0.00s)
    --- FAIL: TestTransportRequestWriteRoundTrip/h2 (19.00s)
        --- FAIL: TestTransportRequestWriteRoundTrip/h2/file,_length (17.10s)
            transport_test.go:6037: Put "https://127.0.0.1:50400": write tcp 127.0.0.1:50401->127.0.0.1:50400: write: broken pipe

— watchflakes

@bcmills bcmills mentioned this issue Jul 11, 2023
Closed
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && log ~ `WARNING: DATA RACE` && log ~ `net/http_test.testServerExpect`
2023-07-06 19:41 linux-amd64-race go@312920c0 net/http.TestOnlyWriteTimeout (log) 
==================
WARNING: DATA RACE
Read at 0x00c0004d81e3 by goroutine 12452:
  testing.(*common).logDepth()
      /workdir/go/src/testing/testing.go:998 +0x4c4
  testing.(*common).log()
      /workdir/go/src/testing/testing.go:985 +0xa4
  testing.(*common).Logf()
      /workdir/go/src/testing/testing.go:1036 +0x6a
  net/http_test.testServerExpect.func2.1()
...
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1906 +0xb44
  net/http_test.TestMain()
      /workdir/go/src/net/http/main_test.go:23 +0x2e
  main.main()
      _testmain.go:1119 +0x324
==================
--- FAIL: TestOnlyWriteTimeout (0.00s)
    --- FAIL: TestOnlyWriteTimeout/h1 (0.02s)
        testing.go:1446: race detected during execution of test
2023-07-06 19:41 linux-amd64-race go@312920c0 net/http.TestTLSServerRejectHTTPRequests (log) 
--- FAIL: TestTLSServerRejectHTTPRequests (0.00s)
    --- FAIL: TestTLSServerRejectHTTPRequests/h2 (0.03s)
        testing.go:1446: race detected during execution of test
2023-07-06 19:41 linux-amd64-race go@312920c0 net/http.TestIdentityResponse (log) 
--- FAIL: TestIdentityResponse (0.00s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gopherbot