Skip to content

cmd/compile: multiple memories live at block start [1.20 backport] #59975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue May 4, 2023 · 2 comments
Closed

cmd/compile: multiple memories live at block start [1.20 backport] #59975

gopherbot opened this issue May 4, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.20.5

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #59973 to be considered for backport to the next 1.20 minor release.

@gopherbot Please open backport issues.

This bug can lead to compiler crashes which would be hard to work around.
I'm not sure if it could lead to miscompilation. But maybe?

It is GOAMD64=v3 only.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 4, 2023
@gopherbot gopherbot mentioned this issue May 4, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 4, 2023
@gopherbot gopherbot added this to the Go1.20.5 milestone May 4, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/492696 mentions this issue: [release-branch.go1.20] cmd/compile: fix bswap/load rewrite rules

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label May 10, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 10, 2023
gopherbot pushed a commit that referenced this issue May 11, 2023
@randall77 @cherrymui
[release-branch.go1.20] cmd/compile: fix bswap/load rewrite rules
afbe101 
When combining a byteswap and a load, the resulting combined op
must go in the load's block, not the byteswap's block, as the load
has a memory argument that might only be valid in its original block.

Fixes #59975

Change-Id: Icd84863ef3a9ca1fc22f2bb794a003f2808c746f
Reviewed-on: https://go-review.googlesource.com/c/go/+/492616
Run-TryBot: Keith Randall <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Wayne Zuo <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
(cherry picked from commit 1014167)
Reviewed-on: https://go-review.googlesource.com/c/go/+/492696
@gopherbot
Copy link
Contributor Author

Closed by merging afbe101 to release-branch.go1.20.

bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@randall77 @bradfitz
[release-branch.go1.20] cmd/compile: fix bswap/load rewrite rules
658ef0d 
When combining a byteswap and a load, the resulting combined op
must go in the load's block, not the byteswap's block, as the load
has a memory argument that might only be valid in its original block.

Fixes golang#59975

Change-Id: Icd84863ef3a9ca1fc22f2bb794a003f2808c746f
Reviewed-on: https://go-review.googlesource.com/c/go/+/492616
Run-TryBot: Keith Randall <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Wayne Zuo <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
(cherry picked from commit 1014167)
Reviewed-on: https://go-review.googlesource.com/c/go/+/492696
bradfitz pushed a commit to tailscale/go that referenced this issue May 25, 2023
@randall77 @bradfitz
[release-branch.go1.20] cmd/compile: fix bswap/load rewrite rules
0079096 
When combining a byteswap and a load, the resulting combined op
must go in the load's block, not the byteswap's block, as the load
has a memory argument that might only be valid in its original block.

Fixes golang#59975

Change-Id: Icd84863ef3a9ca1fc22f2bb794a003f2808c746f
Reviewed-on: https://go-review.googlesource.com/c/go/+/492616
Run-TryBot: Keith Randall <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Wayne Zuo <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
(cherry picked from commit 1014167)
Reviewed-on: https://go-review.googlesource.com/c/go/+/492696
@golang golang locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.20.5
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui