-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: go test
deadlocked without enforcing timeouts when killed with ^C
#60203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this is a regression from CL 448357. It |
I've also been having deadlocks for a few months when ^Cing Here's some output after I ctrl+C:
Here's some output of
Please let me know if this is related / if you'd like me to look into more. |
@twmb, thanks for the report! Unfortunately there isn't a lot I can do to diagnose it from the |
Change https://go.dev/cl/503936 mentions this issue: |
@gopherbot, please backport to Go 1.20. This was a regression in Go 1.20, and causes annoying deadlocks (a UX issue) when attempting to cancel test runs. |
Backport issue(s) opened: #60849 (for 1.20). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
Change https://go.dev/cl/504062 mentions this issue: |
… test actions when interrupted Fixes #60849. Updates #60203. Change-Id: I59a3320ede1eb3cf4443d7ea37b8cb39d01f222a Reviewed-on: https://go-review.googlesource.com/c/go/+/503936 Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> (cherry picked from commit 6087671) Reviewed-on: https://go-review.googlesource.com/c/go/+/504062 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
What version of Go are you using (
go version
)?What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
go test cmd/go/...
, then try to kill the test by sending^C
from the terminal session.What did you expect to see?
Ideally: test terminates ~immediately.
Acceptable: test terminates after a short delay.
Marginally ok: test completes, fails, or times out as usual.
What did you see instead?
The
go test
process deadlocked for ~20h, when the test timeout is normally 10m.The text was updated successfully, but these errors were encountered: