x/tools/internal/typesinternal: invalid linkname

[egonelbre]

https://github.com/golang/tools/blob/07293620cd9cc9bc10c20dfc853c406da3dcab72/internal/typesinternal/types.go#L60

While discussing linkname in #darkarts in Gophers Slack, this code came up. It looks like the newEncoderFor func doesn't exist anymore.

// NewObjectpathEncoder returns a function closure equivalent to
// objectpath.For but amortized for multiple (sequential) calls.
// It is a temporary workaround, pending the approval of proposal 58668.
//
//go:linkname NewObjectpathFunc golang.org/x/tools/go/types/objectpath.newEncoderFor
func NewObjectpathFunc() func(types.Object) (objectpath.Path, error)

newEncoderFor was removed in golang/tools@a5338c9 (CC @adonovan)

I'm not aware that it's causing any problems. I'm guessing NewObjectpathFunc needs to be removed as well.

[gopherbot]

Change https://go.dev/cl/496875 mentions this issue: internal/typesinternal: remove NewObjectpathFunc