Skip to content

cmd/go: go mod tidy introduces ambiguous imports in pruned modules [1.19 backport] #60351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue May 22, 2023 · 2 comments
Closed

cmd/go: go mod tidy introduces ambiguous imports in pruned modules [1.19 backport] #60351

gopherbot opened this issue May 22, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.19.11

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #60313 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19 and 1.20. This bug causes go mod tidy to produce go.mod files that then fail on subsequent go mod tidy invocations. That happens only rarely, but the failure mode is confusing and the workarounds are not obvious.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 22, 2023
@gopherbot gopherbot mentioned this issue May 22, 2023
Closed
@gopherbot gopherbot added this to the Go1.19.10 milestone May 22, 2023
@heschi heschi added the GoCommand cmd/go label May 24, 2023
@nashqueue nashqueue mentioned this issue May 24, 2023
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/499636 mentions this issue: [release-branch.go1.19] cmd/go: retain extra roots to disambiguate imports in 'go mod tidy'

@gopherbot gopherbot modified the milestones: Go1.19.10, Go1.19.11 Jun 6, 2023
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jun 13, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 13, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging f394cd7 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Jun 19, 2023
@gopherbot
[release-branch.go1.19] cmd/go: retain extra roots to disambiguate im…
f394cd7 
…ports in 'go mod tidy'

We don't normally keep explicit requirements for test dependencies of
packages loaded from other modules when the required version is
already the selected version in the module graph. However, in some
cases we may need to keep an explicit requirement in order to make use
of lazy module loading to disambiguate an otherwise-ambiguous import.

Note that there is no Go version guard for this change: in the cases
where the behavior of 'go mod tidy' has changed, previous versions of
Go would produce go.mod files that break successive calls to
'go mod tidy'. Given that, I suspect that any existing user in the
wild affected by this bug either already has a workaround in place
using redundant import statements (in which case the change does not
affect them) or is running 'go mod tidy -e' to force past the error
(in which case a change in behavior to a non-error should not be
surprising).

Updates #60313.
Fixes #60351.

Change-Id: Idf294f72cbe3904b871290d79e4493595a0c7bfc
Reviewed-on: https://go-review.googlesource.com/c/go/+/496635
Auto-Submit: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit 2ed6a54)
Reviewed-on: https://go-review.googlesource.com/c/go/+/499636
TryBot-Bypass: Bryan Mills <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
@golang golang locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.19.11
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @heschi