Skip to content

text/template: key/value assignment is reversed within range loop [1.20 backport] #60802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jun 14, 2023 · 2 comments
Closed

text/template: key/value assignment is reversed within range loop [1.20 backport] #60802

gopherbot opened this issue Jun 14, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.6

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jun 14, 2023 •
edited by ianlancetaylor
Loading

@ianlancetaylor requested issue #60801 to be considered for backport to the next 1.20 minor release.

@gopherbot Please open backport to 1.20.

This is a regression since previous versions.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 14, 2023
@gopherbot gopherbot mentioned this issue Jun 14, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.6 milestone Jun 14, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/503576 mentions this issue: [release-branch.go1.20] text/template: set variables correctly in range assignment

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jun 21, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging 0306310 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Jun 21, 2023
@ianlancetaylor
[release-branch.go1.20] text/template: set variables correctly in ran…
0306310 
…ge assignment

I unintentionally flipped them in CL 446795.

For #56490
For #60801
Fixes #60802

Change-Id: I57586bec052e1b2cc61513870ce24dd6ce17e56b
Reviewed-on: https://go-review.googlesource.com/c/go/+/503576
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
@golang golang locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.6
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot