Skip to content

os/exec: TestConcurrentExec failures with context canceled #61277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jul 11, 2023 · 12 comments
Closed

os/exec: TestConcurrentExec failures with context canceled #61277

gopherbot opened this issue Jul 11, 2023 · 12 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jul 11, 2023 •
edited by bcmills
Loading 

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec" && `context canceled`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestConcurrentExec (0.01s)
    exec_test.go:1757: context canceled

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec"
2023-07-10 19:19 linux-amd64-nocgo go@07ede7a5 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.01s)
    exec_test.go:1757: context canceled

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec"
2023-07-10 19:19 freebsd-arm64-dmgk go@07ede7a5 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.01s)
    exec_test.go:1757: context canceled
2023-07-10 19:19 linux-ppc64-sid-power10 go@07ede7a5 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.00s)
    exec_test.go:1757: context canceled

— watchflakes

@bcmills bcmills added this to the Go1.21 milestone Jul 11, 2023
@bcmills bcmills self-assigned this Jul 11, 2023
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jul 11, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec"
2023-07-11 00:36 linux-amd64-bookworm go@6a063b01 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 00:36 netbsd-386-9_3 go@6a063b01 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec"
2023-07-11 00:36 linux-ppc64le-power10osu go@6a063b01 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled

— watchflakes

@bcmills bcmills changed the title os/exec: TestConcurrentExec failures os/exec: TestConcurrentExec failures with context canceled Jul 11, 2023
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 11, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/508755 mentions this issue: os/exec: ignore context.Canceled errors in TestConcurrentExec

@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec" && `context canceled`
2023-07-11 13:19 linux-amd64-nocgo go@4c58d6bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec" && `context canceled`
2023-07-11 00:36 linux-arm-aws go@6a063b01 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 00:36 linux-ppc64-sid-buildlet go@6a063b01 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 13:19 freebsd-386-13_0 go@4c58d6bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 13:19 freebsd-amd64-13_0 go@4c58d6bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.03s)
    exec_test.go:1757: context canceled
    exec_test.go:1757: context canceled
2023-07-11 13:19 linux-arm-aws go@4c58d6bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 13:19 linux-ppc64-sid-buildlet go@4c58d6bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec" && `context canceled`
2023-07-11 13:19 linux-ppc64le-power9osu go@4c58d6bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 13:19 netbsd-amd64-9_3 go@4c58d6bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.03s)
    exec_test.go:1757: context canceled
2023-07-11 16:33 linux-amd64-bullseye go@3f8b04bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 16:33 linux-ppc64-sid-power10 go@3f8b04bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.00s)
    exec_test.go:1757: context canceled
2023-07-11 16:33 netbsd-amd64-9_3 go@3f8b04bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.03s)
    exec_test.go:1757: context canceled

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec" && `context canceled`
2023-07-11 17:06 android-amd64-emu go@65186971 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 17:06 linux-386-softfloat go@65186971 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 17:06 linux-amd64-nocgo go@65186971 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.01s)
    exec_test.go:1757: context canceled
2023-07-11 17:06 linux-ppc64-sid-buildlet go@65186971 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.01s)
    exec_test.go:1757: context canceled

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec" && `context canceled`
2023-07-11 17:06 freebsd-arm64-dmgk go@65186971 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled
2023-07-11 17:06 linux-ppc64le-power9osu go@65186971 os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.02s)
    exec_test.go:1757: context canceled

— watchflakes

bradfitz pushed a commit to tailscale/go that referenced this issue Jul 15, 2023
@bradfitz
os/exec: ignore context.Canceled errors in TestConcurrentExec
4493294 
We cancel the Context to unblock the test as soon as all of the "exit"
processes have completed. If that happens to occur before all of the
"hang" processes have started, the Start calls may fail with
context.Canceled.

Since those errors are possible in normal operation of the test,
ignore them.

Fixes golang#61277.
Updates golang#61080.

Change-Id: I20db083ec89ca88eb085ceb2892b9f87f83705ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/508755
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "os/exec" && test == "TestConcurrentExec" && `context canceled`
2023-07-11 13:19 netbsd-arm64-bsiegert go@4c58d6bf os/exec.TestConcurrentExec (log) 
--- FAIL: TestConcurrentExec (0.04s)
    exec_test.go:1757: context canceled

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Sep 8, 2023

Old flakes are old. 🤷‍♂️

@golang golang locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot