Skip to content

cmd/compile: internal compiler error: 'F': func F, startMem[b1] has different values [1.21 backport] #62057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 15, 2023 · 3 comments
Closed

cmd/compile: internal compiler error: 'F': func F, startMem[b1] has different values [1.21 backport] #62057

gopherbot opened this issue Aug 15, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.21.1

Comments

@gopherbot
Copy link
Contributor

@dr2chase requested issue #61992 to be considered for backport to the next 1.21 minor release.

@gopherbot please open the backport tracking issues. This is a use-blocking compiler bug.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 15, 2023
@gopherbot gopherbot mentioned this issue Aug 15, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 15, 2023
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 15, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/520058 mentions this issue: [release-branch.go1.21] cmd/compile: in expandCalls, move all arg marshalling into call block

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 24, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 24, 2023
@cagedmantis
Copy link
Contributor

Approved as this is a serious issue without a workaround.

@gopherbot
Copy link
Contributor Author

Closed by merging 2b8026f to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Aug 24, 2023
@dr2chase @cagedmantis
[release-branch.go1.21] cmd/compile: in expandCalls, move all arg mar…
2b8026f 
…shalling into call block

For aggregate-typed arguments passed to a call, expandCalls
decomposed them into parts in the same block where the value
was created.  This is not necessarily the call block, and in
the case where stores are involved, can change the memory
leaving that block, and getting that right is problematic.

Instead, do all the expanding in the same block as the call,
which avoids the problems of (1) not being able to reorder
loads/stores across a block boundary to conform to memory
order and (2) (incorrectly, not) exposing the new memory to
consumers in other blocks.  Putting it all in the same block
as the call allows reordering, and the call creates its own
new memory (which is already dealt with correctly).

Fixes #62057.
Updates #61992.

Change-Id: Icc7918f0d2dd3c480cc7f496cdcd78edeca7f297
Reviewed-on: https://go-review.googlesource.com/c/go/+/519276
Reviewed-by: Keith Randall <[email protected]>
Run-TryBot: David Chase <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit e72ecc6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/520058
@golang golang locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot