Skip to content

net: TCPConn.ReadFrom hangs when io.Reader is TCPConn or UnixConn, Linux kernel < 5.1 [1.21 backport] #63801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Oct 28, 2023 · 11 comments
Closed

net: TCPConn.ReadFrom hangs when io.Reader is TCPConn or UnixConn, Linux kernel < 5.1 [1.21 backport] #63801

gopherbot opened this issue Oct 28, 2023 · 11 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.21.5

Comments

@gopherbot
Copy link
Contributor

@panjf2000 requested issue #63795 to be considered for backport to the next 1.21 minor release.

@sebastien-rosset Thanks for your efforts here.

Although this problem was caused by the CL in #59041, that issue focused on another problem originally, therefore I asked to open a new issue for this problem solely, for tracking purposes.

@gopherbot please consider this for backport to go1.21, it's a regression.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 28, 2023
@gopherbot gopherbot mentioned this issue Oct 28, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.4 milestone Oct 28, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/538117 mentions this issue: [release-branch.go1.21] internal/poll: add SPLICE_F_NONBLOCK flag for splice to avoid inconsistency with O_NONBLOCK

@cherrymui cherrymui added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 1, 2023
@cherrymui
Copy link
Member

waiting for #63795 to be fixed.

@sebastien-rosset
Copy link

I see the fix has been committed to master: https://go-review.googlesource.com/c/go/+/536015, presumably it needs to be back-ported to 1.21.x and 1.22.x.

@cherrymui
Copy link
Member

@sebastien-rosset Go 1.22 is not released yet, so there is no backport to Go 1.22.x. #63795 is still open, and it is not really clear if there is anything more needed to be done. We will take another look next week if things are clear by then. Thanks.

@sebastien-rosset
Copy link

Thanks. How about back porting to 1.21?

@cherrymui
Copy link
Member

Backporting to 1.21 is this issue. We are waiting for #63795 to be closed.

@rabadin
Copy link

rabadin commented Nov 7, 2023 •
edited
Loading

@cherrymui Looks like #63795 is fixed now... will the backport to 1.21 (https://go-review.googlesource.com/c/go/+/538117) be included in the upcoming 1.21.* release?

@bcmills
Copy link
Contributor

bcmills commented Nov 7, 2023

@rabadin, I would expect that it will not be, since the backport change is not yet merged. Probably the next 1.21.* point release after this one.

@cherrymui
Copy link
Member

Thanks for the update.

@cherrymui cherrymui removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 7, 2023
@rabadin
Copy link

rabadin commented Nov 7, 2023

Thanks the the heads up @bcmills.

@gopherbot gopherbot modified the milestones: Go1.21.4, Go1.21.5 Nov 7, 2023
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Nov 8, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 8, 2023
gopherbot pushed a commit that referenced this issue Nov 8, 2023
@panjf2000 @gopherbot
[release-branch.go1.21] internal/poll: add SPLICE_F_NONBLOCK flag for…
8ae493b 
… splice to avoid inconsistency with O_NONBLOCK

Fixes #63801
Updates #59041
Updates #63795

Details: #59041 (comment)

Change-Id: Id3fc1df6d86b7c4cc383d09f9465fa8f4cc2a559
Reviewed-on: https://go-review.googlesource.com/c/go/+/536015
Reviewed-by: Bryan Mills <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
(cherry picked from commit 40cdf69)
Reviewed-on: https://go-review.googlesource.com/c/go/+/538117
Auto-Submit: Heschi Kreinick <[email protected]>
Reviewed-by: Mauri de Souza Meneguzzo <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 8ae493b to release-branch.go1.21.

@hawkingrei hawkingrei mentioned this issue Dec 6, 2023
Closed
@golang golang locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.21.5
Development

No branches or pull requests
6 participants
@bcmills @gopherbot @cherrymui @sebastien-rosset @rabadin @heschi