Skip to content

maps: maps.Clone reference semantics when cloning a map with large value types [1.21 backport] #64475

Closed
Closed
maps: maps.Clone reference semantics when cloning a map with large value types [1.21 backport]#64475
Labels
CherryPickApprovedUsed during the release process for point releasesFrozenDueToAgecompiler/runtimeIssues related to the Go compiler and/or runtime.
Milestone
Go1.21.6

Description

@gopherbot
gopherbot
opened on Nov 30, 2023

@bcmills requested issue #64474 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. This appears to cause subtle aliasing bugs in cloned maps.

Activity

  1. gopherbot
    added
    CherryPickCandidateUsed during the release process for point releases
    on Nov 30, 2023
  2. gopherbot
    added this to the Go1.21.5 milestone on Nov 30, 2023
  3. bcmills
    added
    compiler/runtimeIssues related to the Go compiler and/or runtime.
    on Nov 30, 2023

  4. bcmills commented on Nov 30, 2023

    @bcmills
    bcmills
    on Nov 30, 2023
    Contributor

    (Note that the maps package was added in Go 1.21, so this does not also need to be backported to Go 1.20.)

  5. gopherbot commented on Dec 5, 2023

    @gopherbot
    gopherbot
    on Dec 5, 2023
    ContributorAuthor

    Change https://go.dev/cl/547375 mentions this issue: [release-branch.go1.21] maps: fix aliasing problems with Clone

  6. gopherbot
    modified the milestones: Go1.21.5, Go1.21.6 on Dec 5, 2023

  7. cagedmantis commented on Dec 6, 2023

    @cagedmantis
    cagedmantis
    on Dec 6, 2023
    Contributor

    Approved. It's a serious issue without a workaround.

  8. cagedmantis
    added
    CherryPickApprovedUsed during the release process for point releases
    on Dec 6, 2023
  9. gopherbot
    removed
    CherryPickCandidateUsed during the release process for point releases
    on Dec 6, 2023

  10. gopherbot commented on Jan 4, 2024

    @gopherbot
    gopherbot
    on Jan 4, 2024
    ContributorAuthor

    Closed by merging f6b203c to release-branch.go1.21.

  11. gopherbot
    closed this as completedon Jan 4, 2024
  12. gopherbot
    added a commit that references this issue on Jan 4, 2024

    [release-branch.go1.21] maps: fix aliasing problems with Clone

    f6b203c
  13. golang
    locked and limited conversation to collaborators on Jan 3, 2025
  14. gopherbot
    added
    FrozenDueToAge
    on Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CherryPickApprovedUsed during the release process for point releasesFrozenDueToAgecompiler/runtimeIssues related to the Go compiler and/or runtime.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions