-
Notifications
You must be signed in to change notification settings - Fork 18k
x/build: add 1.23 and tip builders with GODEBUG=gotypesalias=1 for at least the x/tools repo #68798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related Issues and Documentation (Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.) |
These builders were recently updated in CL 601177 to stop existing after 1.22 based on the idea that 1.23 and later already default to GODEBUG=gotypesalias=1. I'll refine that to keep them around for 1.23 and 1.24 as well. |
Thanks very much @dmitshur! Would it be possible to add the tip builder to the default presubmit tryset as well? |
Change https://go.dev/cl/604335 mentions this issue: |
Change https://go.dev/cl/604336 mentions this issue: |
New information in go.dev/issue/68798 shows that having this builder available for 1.23 and at tip will be helpful, at least in the short term. Also run it in postsubmit (for 1.23/tip only, where it's meant to pass), and also in presubmit as of the next CL. For golang/go#68798. Change-Id: I72183cc8703b65ecb265e01b18288651a7e64cfb Reviewed-on: https://go-review.googlesource.com/c/build/+/604335 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Tim King <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
This is separated out in a separate CL for a more gradual rollout. Fixes golang/go#68798. Change-Id: I6a4c2f1e89ab7c6426a9b5d19e429b68ca61bee4 Reviewed-on: https://go-review.googlesource.com/c/build/+/604336 Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Tim King <[email protected]> Reviewed-by: David Chase <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Closed by merging CL 604336 (commit golang/build@8cb2bf7) to |
This comment was marked as duplicate.
This comment was marked as duplicate.
Change https://go.dev/cl/648695 mentions this issue: |
Based on the issue, these builders weren't intended to stick around beyond Go 1.24. Update 'exists' to take into account that Go tip is at 1.25, and x/tools will soon be upgraded to language version 1.23. For golang/go#68798. Change-Id: I15cb4813026de894ccd6d7dd4c8c5c32cbf114a2 Reviewed-on: https://go-review.googlesource.com/c/build/+/648695 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Robert Findley <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
See #68796 and #68797 for some background on missing test coverage with GODEBUG=gotypesalias=1.
Until x/tools has a go.mod file that says 1.23 (not until at least 1.24 is released), it will lack test coverage of GODEBUG=gotypesalias=1. @timothy-king had added go1.21 and go1.22 builders with GODEBUG=gotypesalias=1; we need them for 1.23 and tip as well.
@timothy-king @dmitshur would you mind adding these as well? CC @adonovan
The text was updated successfully, but these errors were encountered: