Skip to content

go/types: 'under' panics on Alias type [1.23 backport] #68894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 15, 2024 · 2 comments
Closed

go/types: 'under' panics on Alias type [1.23 backport] #68894

gopherbot opened this issue Aug 15, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.23.1

Comments

@gopherbot
Copy link
Contributor

@findleyr requested issue #68877 to be considered for backport to the next 1.23 minor release.

@gopherbot, please create a backport issue for Go 1.23: this is a regression in the type checker when run with GODEBUG=gotypesalias=1, the new default.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 15, 2024
@gopherbot gopherbot mentioned this issue Aug 15, 2024
Closed
@gopherbot gopherbot added this to the Go1.23.1 milestone Aug 15, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/606656 mentions this issue: [release-branch.go1.23] go/types, types2: Named.cleanup must also handle *Alias types

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Aug 21, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 21, 2024
gopherbot pushed a commit that referenced this issue Aug 21, 2024
@griesemer @cherrymui
[release-branch.go1.23] go/types, types2: Named.cleanup must also han…
9166d2f 
…dle *Alias types

Named.cleanup is called at the end of type-checking to ensure that
a named type is fully set up; specifically that it's underlying
field is not (still) a Named type. Now it can also be an *Alias
type. Add this case to the respective type switch.

Fixes #68894.

Change-Id: I29bc0024ac9d8b0152a3d97c82dd28d09d5dbd66
Reviewed-on: https://go-review.googlesource.com/c/go/+/605977
Auto-Submit: Robert Griesemer <[email protected]>
Reviewed-by: Robert Griesemer <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/606656
@gopherbot
Copy link
Contributor Author

Closed by merging CL 606656 (commit 9166d2f) to release-branch.go1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.23.1
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui