Skip to content

crypto/internal/fips/aes/gcm: TestAllocations fails on PPC64 #70448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pmur opened this issue Nov 19, 2024 · 4 comments
Open

crypto/internal/fips/aes/gcm: TestAllocations fails on PPC64 #70448

pmur opened this issue Nov 19, 2024 · 4 comments
Labels
arch-ppc64x NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@pmur
Copy link
Contributor

pmur commented Nov 19, 2024

Go version

master

Output of go env in your module/workspace:

GOARCH=ppc64le

What did you do?

cd crypto/internal/fips/aes/gcm
go test

What did you see happen?

--- FAIL: TestAllocations (0.00s)
ctrkdf_test.go:31: expected zero allocations, got 6.0

What did you expect to see?

All tests pass
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/629697 mentions this issue: crypto/intenral/fips/aes/gcm: skip TestAllocations on PPC64

@dmitshur dmitshur added arch-ppc64x FixPending Issues that have a fix which has not yet been reviewed or submitted. labels Nov 19, 2024
@dmitshur dmitshur added this to the Go1.24 milestone Nov 19, 2024
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 19, 2024
gopherbot pushed a commit that referenced this issue Nov 19, 2024
@pmur
crypto/internal/fips/aes/gcm: skip TestAllocations on PPC64
2e60747 
TestAllocations is failing on PPC64 causing all PPC64 CI to fail.

Skip the test until it can be debugged.

For #70448

Change-Id: Ic18e402f4af5939a90eba2e1f2b182699013ed55
Reviewed-on: https://go-review.googlesource.com/c/go/+/629697
Reviewed-by: Filippo Valsorda <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
@pmur
Copy link
Contributor Author

pmur commented Nov 19, 2024

@golang/ppc64

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/636055 mentions this issue: crypto/internal/fips140test: skip TestXAESAllocations on s390x

gopherbot pushed a commit that referenced this issue Dec 13, 2024
@FiloSottile @gopherbot
crypto/internal/cryptotest: skip TestAllocations on s390x
08725f9 
TestXAESAllocations fails like #70448, and crypto/rand's fails in FIPS
mode. We can't keep chasing these without even a LUCI builder.

Updates #67307

Change-Id: I5d0edddf470180a321dec55cabfb018db62eb940
Reviewed-on: https://go-review.googlesource.com/c/go/+/636055
Auto-Submit: Filippo Valsorda <[email protected]>
Reviewed-by: Roland Shoemaker <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
@gopherbot gopherbot modified the milestones: Go1.24, Go1.25 Feb 11, 2025
@FiloSottile FiloSottile added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. labels Feb 27, 2025
@FiloSottile FiloSottile modified the milestones: Go1.25, Backlog Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-ppc64x NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@FiloSottile @dmitshur @gopherbot @pmur @gabyhelp