Skip to content

x/tools/cmd/signature-fuzzer: test failures when module's language version is 1.24 #71613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitshur opened this issue Feb 7, 2025 · 2 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@dmitshur
Copy link
Member

dmitshur commented Feb 7, 2025

When x/tools' go.mod is updated to Go language 1.24 or newer (which will happen this August based on https://go.dev/s/release#timeline and https://go.dev/design/69095-x-repo-continuous-go#why-1_n_1_0), there are some tests in cmd/signature-fuzzer that will begin to fail:

tools $ go test -count=1 ./cmd/signature-fuzzer/internal/fuzz-generator 
ok  	golang.org/x/tools/cmd/signature-fuzzer/internal/fuzz-generator	6.828s
tools $ go mod edit -go=1.24
tools $ go test -count=1 ./cmd/signature-fuzzer/internal/fuzz-generator
wraprand consistency check failed:
 checker: {f32:3 f64:12 i:76}
 caller: {f32:3 f64:12 i:77}
--- FAIL: TestIsBuildable (0.13s)
panic: bad [recovered]
	panic: bad
[…]
tools $ go mod edit -go=1.22.0                                         
tools $ go test -count=1 ./cmd/signature-fuzzer/internal/fuzz-generator
ok  	golang.org/x/tools/cmd/signature-fuzzer/internal/fuzz-generator	7.012s
[...]

This is being reported early thanks to a -tiplang builder (see https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-linux-amd64-tiplang). It's not necessarily a problem today since x/tools/go.mod's go directive is at 1.22.0, but does need to be investigated and fixed at some point, and this is the tracking issue for that.

CC @golang/tools-team.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 7, 2025
@dmitshur dmitshur added this to the Unreleased milestone Feb 7, 2025
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 7, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/647896 mentions this issue: cmd/signature-fuzzer/internal/fuzz-generator: update to math/rand/v2

@dmitshur dmitshur added FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 9, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/648676 mentions this issue: main.star: remove known issues for -tiplang builder in x/crypto, x/tools

gopherbot pushed a commit to golang/build that referenced this issue Feb 11, 2025
They're both fixed.

For golang/go#71612.
For golang/go#71613.

Change-Id: I7274cd5314c02cc01fda2ed1fd3a11d424349278
Reviewed-on: https://go-review.googlesource.com/c/build/+/648676
Auto-Submit: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants