Skip to content

website: space doesn't scroll in Firefox #8300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jun 29, 2014 · 15 comments
Closed

website: space doesn't scroll in Firefox #8300

gopherbot opened this issue Jun 29, 2014 · 15 comments
Labels
FrozenDueToAge
Milestone
Go1.3.1

Comments

@gopherbot
Copy link
Contributor

by [email protected]:

On the golang.org pages (eg, http://golang.org/pkg/ and
http://golang.org/doc/effective_go.html) the space key doesn't scroll down. Arrow keys
and page up/down keys work.

This does work in Chrome, and it works on other pages with my copy of Firefox as well.
@ianlancetaylor
Copy link
Contributor

Comment 1:

Labels changed: added repo-main, release-none.

@gopherbot
Copy link
Contributor Author

Comment 2 by tommost:

For me the arrow keys don't work on page load in Firefox or Chrome.  This appears to be
caused by styles on the wrapping div, #mainframe: "position: fixed; bottom: 0; top:0;
overflow: auto; width: 100%;".  Making the main scrolling region anything but
<body> also triggers nasty, slow scrolling in Firefox for Android.

@adg
Copy link
Contributor

adg commented Jul 15, 2014

Comment 3:

Can anyone suggest a fix?
CSS is seriously annoying.

Status changed to Accepted.

@adg
Copy link
Contributor

adg commented Jul 15, 2014

Comment 4:

Alan, you added the mainframe div in
https://code.google.com/p/go/source/detail?r=0e4df5fb7982&repo=tools
My apologies for not reviewing it closely enough. We shouldn't have to wrap all the page
content to add the lower box for static analysis results.

Owner changed to @adonovan.

@gopherbot
Copy link
Contributor Author

Comment 5 by tommost:

I fixed it with a Greasemonkey script which does the following:
    $('#mainframe').attr('style', '');
    $('#lowframe').css('position', 'fixed');
Basically just remove the style attribute from <div id="mainframe"></div>
and make the lowframe fixed-position instead of absolute.
I can't find any page where <div id="lowframe"></div> actually has content,
though, so I can't test it thoroughly.

@adg
Copy link
Contributor

adg commented Jul 15, 2014

Comment 6:

https://golang.org/cl/113130044

Owner changed to @adg.

Status changed to Started.

@adg
Copy link
Contributor

adg commented Jul 15, 2014

Comment 7:

Thanks tommost: you're right, the mainframe can be removed entirely. The lowframe div is
used by pointer analysis, enabled with -analysis=pointer, and can be seen by browsing to
a function declaration in code and clicking the "func" keyword.

@gopherbot
Copy link
Contributor Author

Comment 8:

CL https://golang.org/cl/113130044 mentions this issue.

@adg
Copy link
Contributor

adg commented Jul 15, 2014

Comment 9:

This issue was closed by revision golang/tools@cc0b856.

Status changed to Fixed.

@adg
Copy link
Contributor

adg commented Jul 16, 2014

Comment 10:

Labels changed: added release-go1.3.1, removed release-none.

@adg
Copy link
Contributor

adg commented Jul 16, 2014

Comment 11:

Labels changed: added repo-tools, removed repo-main.

@adg
Copy link
Contributor

adg commented Jul 21, 2014

Comment 12:

Issue #8392 has been merged into this issue.

@adg
Copy link
Contributor

adg commented Jul 21, 2014

Comment 13:

This issue was closed by revision 740cf087300b.

@rsc
Copy link
Contributor

rsc commented Aug 11, 2014

Comment 14:

HTML-only fix.
Approved for Go 1.3.1.

@adg
Copy link
Contributor

adg commented Aug 11, 2014

Comment 15:

Applied to release-branch.go1.3.

@adg adg mentioned this issue Dec 8, 2014
Closed
@rsc rsc added this to the Go1.3.1 milestone Apr 14, 2015
adg added a commit to golang/tools that referenced this issue May 11, 2015
@adg
[release-branch.go1.3] go.tools/godoc/static: remove unnecessary main…
3e9181f 
…frame wrapper

««« CL 113130044 / c60f58db34e9
go.tools/godoc/static: remove unnecessary mainframe wrapper

Fixes golang/go#8300.

LGTM=adonovan
R=golang-codereviews, adonovan, bradfitz
CC=golang-codereviews
https://golang.org/cl/113130044
»»»

TBR=rsc
R=golang-codereviews
CC=golang-codereviews
https://golang.org/cl/112510043
@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc unassigned adg Jun 23, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.3.1
Development

No branches or pull requests
4 participants
@rsc @ianlancetaylor @adg @gopherbot