Repository navigation
missing unlock in crypt/rand/rand_unix.go #917
Description
Just noticed on , http://code.google.com/p/go/source/browse/src/pkg/crypto/rand/rand_unix.go?spec=svn42e4767b10beb7eeb7a3c7db372279e8c01b45c3&;r=42e4767b10beb7eeb7a3c7db372279e8c01b45c3 func (r *devReader) Read(b []byte) (n int, err os.Error) { r.mu.Lock() if r.f == nil { f, err := os.Open(r.name, os.O_RDONLY, 0) if f == nil { >>>>>>>>>>>>>>>>>>>>>>> /// MISSING m.mu.Unlock() return 0, err } r.f = f } r.mu.Unlock() return r.f.Read(b) }
Activity
rsc commentedon Jul 13, 2010
Comment 1:
Owner changed to r...@golang.org.
Status changed to Started.
peterGo commentedon Jul 13, 2010
Comment 2:
bradfitz commentedon Jul 13, 2010
Comment 3:
$ hg diff pkg/crypto/rand/rand_windows.go diff -r 4f91458c5765 src/pkg/crypto/rand/rand_windows.go --- a/src/pkg/crypto/rand/rand_windows.go Tue Jul 13 10:47:52 2010 +1000 +++ b/src/pkg/crypto/rand/rand_windows.go Tue Jul 13 11:09:52 2010 -0700 @@ -30,6 +30,7 @@ const flags = syscall.CRYPT_VERIFYCONTEXT | syscall.CRYPT_SILENT ok, errno := syscall.CryptAcquireContext(&r.prov, nil, nil, provType, flags) if !ok { + r.mu.Unlock() return 0, os.NewSyscallError("CryptAcquireContext", errno) } }peterGo commentedon Jul 13, 2010
Comment 4:
bradfitz commentedon Jul 13, 2010
Comment 5:
robpike commentedon Jul 14, 2010
Comment 6:
Status changed to Fixed.