net/http: fix build errors on js/wasm target

[johanbrandhorst]

The in-progress WASM port does not yet have sufficient automatic
testing performed against it, so these errors slipped through when
adding the new Fetch API backed http.Roundtripper.

Updates #25506

[gopherbot]

This PR (HEAD: e6dc6ec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/116076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Richard Musiol:

Patch Set 1:

This is a good start, but it does not yet fully fix the tests of net/http. The reason is that useFakeNetwork returns false, because os.Args is this:

[/var/folders/sy/qczh9gpd5f51brb923qxb6vr0000gn/T/go-build207682035/b001/http.test -test.short=true -test.run=Test -test.v=true]

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/116076.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Johan Brandhorst:

Patch Set 1:

Patch Set 1:

This is a good start, but it does not yet fully fix the tests of net/http. The reason is that useFakeNetwork returns false, because os.Args is this:

[/var/folders/sy/qczh9gpd5f51brb923qxb6vr0000gn/T/go-build207682035/b001/http.test -test.short=true -test.run=Test -test.v=true]

Ah so Brad's suggestion of using "node" is not sufficient here. Any other suggestions on how we could turn this on for tests alone? Is "http.test" something we could rely on instead?

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/116076.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Richard Musiol:

Patch Set 1:

Patch Set 1:

Patch Set 1:

This is a good start, but it does not yet fully fix the tests of net/http. The reason is that useFakeNetwork returns false, because os.Args is this:

[/var/folders/sy/qczh9gpd5f51brb923qxb6vr0000gn/T/go-build207682035/b001/http.test -test.short=true -test.run=Test -test.v=true]

Ah so Brad's suggestion of using "node" is not sufficient here. Any other suggestions on how we could turn this on for tests alone? Is "http.test" something we could rely on instead?

The main problem is that you need to use the fake networking not only for the tests of net/http, but also for other packages that use net/http in their tests. For those packages the binary wouldn't be "http.test".

Maybe we should use a build tag and then have the js/wasm tests use that build tag? @brad What do you think?

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/116076.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review+2

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/116076.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 064062b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/116076 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Johan Brandhorst:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/116076.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/116076 has been merged.