httptest: guarantee ResponseRecorder.Result returns a non-nil body #26453
Conversation
googlebot
added
the
cla: yes
|
Message from Gerrit User 5065: Patch Set 1: (2 comments) Could you also add/update a test? Please don’t reply on this GitHub thread. Visit golang.org/cl/124875. |
jackxbritton
force-pushed
the
issue-26442
branch
from
bf35244 to
694bccd
Compare
|
Message from Gerrit User 12446: Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2. Please don’t reply on this GitHub thread. Visit golang.org/cl/124875. |
|
Message from Gerrit User 28384: Patch Set 3:
Not sure of the best way to create a test for when rec.Body == nil, take a look at the new code. I could just add some code at the end of TestRecorder.. thoughts? Please don’t reply on this GitHub thread. Visit golang.org/cl/124875. |
gopherbot
force-pushed
the
master
branch
7 times, most recently
from
d278f09 to
eec9a89
Compare
…l body The doc for ResponseRecorder.Result guarantees that the body of the returned http.Response will be non-nil, but this is only true if the caller's body is non-nil. With this change, if the caller's body is nil then the returned response's body will be an empty io.ReadCloser.
jackxbritton
force-pushed
the
issue-26442
branch
from
694bccd to
d802967
Compare
|
Message from Gerrit User 12446: Uploaded patch set 5: New patch set was added with same tree, parent, and commit message as Patch Set 4. Please don’t reply on this GitHub thread. Visit golang.org/cl/124875. |
|
Message from Gerrit User 5065: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/124875. |
|
Message from Gerrit User 5065: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/124875. |
…l body The doc for ResponseRecorder.Result guarantees that the body of the returned http.Response will be non-nil, but this only holds true if the caller's body is non-nil. With this change, if the caller's body is nil then the returned response's body will be an empty io.ReadCloser. Fixes #26442 Change-Id: I3b2fe4a2541caf9997dbb8978bbaf1f58cd1f471 GitHub-Last-Rev: d802967 GitHub-Pull-Request: #26453 Reviewed-on: https://go-review.googlesource.com/124875 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]>
gopherbot
force-pushed
the
master
branch
5 times, most recently
from
0090c13 to
8fbbf63
Compare
|
This PR is being closed because golang.org/cl/124875 has been merged. |
The doc for ResponseRecorder.Result guarantees that the body of the returned
http.Response will be non-nil, but this only holds true if the caller's body is
non-nil. With this change, if the caller's body is nil then the returned
response's body will be an empty io.ReadCloser.
Fixes #26442