Skip to content

cmd/go: correctly suggest tidy instead of nonexistent fix for -fix #28402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Oct 26, 2018

CL 129682 removed go mod fix but unfortunately
we hadn't updated the source code hence running
go mod -fix
would suggest
go mod fix
which is a nonexistent command.

This change fixes that to instead suggest
go mod tidy

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 26, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: eab1e55) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/144838 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 1:

(2 comments)

Thanks for working on this Yuji!
I've added some suggestions for the commit message and for the fix.

Just in case you might not have seen, please make your commit message
edits on Github as per https://github.com/golang/go/wiki/CommitMessage#github-pull-requests
so that the changes can reflect here.
Thank you!


Please don’t reply on this GitHub thread. Visit golang.org/cl/144838.
After addressing review feedback, remember to publish your drafts!

CL 129682 removed go mod fix but unfortunately
we hadn't updated the source code hence running
   go mod -fix
would suggest
   go mod fix
which is a nonexistent command.

This change fixes that to instead suggest
   go mod tidy
@y-yagi y-yagi force-pushed the do_not_suggest_not_exist_command branch from eab1e55 to 5ae1340 Compare November 15, 2018 22:38
@gopherbot
Copy link
Contributor

This PR (HEAD: 5ae1340) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/144838 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Yuji Yaginuma:

Patch Set 2:

Thanks for your review!

I updated fix and commit message. Thanks!


Please don’t reply on this GitHub thread. Visit golang.org/cl/144838.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 2:

Patch Set 2:

Thanks for your review!

I updated fix and commit message. Thanks!

Thanks Yuji. I don't know if you saw my message in https://go-review.googlesource.com/c/go/+/144838/2#message-ca45c6b738a0aad141a4d1f38fcfd9670aba2733
but anyways to update the commit message and get it to reflect on Gerrit, you'll need to manually go edit the Github PR as per https://github.com/golang/go/wiki/CommitMessage#github-pull-requests. Once that is up, then LGTM.


Please don’t reply on this GitHub thread. Visit golang.org/cl/144838.
After addressing review feedback, remember to publish your drafts!

@odeke-em odeke-em changed the title cmd/go: do not suggest a not exist command cmd/go: correctly suggest tidy instead of nonexistent fix for -fix Nov 15, 2018
@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 4: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/144838.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e8f7e221


Please don’t reply on this GitHub thread. Visit golang.org/cl/144838.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 4:

Patch Set 2:

Patch Set 2:

Thanks for your review!

I updated fix and commit message. Thanks!

Thanks Yuji. I don't know if you saw my message in https://go-review.googlesource.com/c/go/+/144838/2#message-ca45c6b738a0aad141a4d1f38fcfd9670aba2733
but anyways to update the commit message and get it to reflect on Gerrit, you'll need to manually go edit the Github PR as per https://github.com/golang/go/wiki/CommitMessage#github-pull-requests. Once that is up, then LGTM.

Yuji, never mind, I made the edit on Github itself :)


Please don’t reply on this GitHub thread. Visit golang.org/cl/144838.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/144838.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 15, 2018
CL 129682 removed go mod fix but unfortunately
we hadn't updated the source code hence running
   go mod -fix
would suggest
   go mod fix
which is a nonexistent command.

This change fixes that to instead suggest
   go mod tidy

Change-Id: Ie0d7c90805034e9fe6df24afaa15340c44d4f426
GitHub-Last-Rev: 5ae1340
GitHub-Pull-Request: #28402
Reviewed-on: https://go-review.googlesource.com/c/144838
Reviewed-by: Emmanuel Odeke <[email protected]>
Run-TryBot: Emmanuel Odeke <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/144838 has been merged.

@gopherbot gopherbot closed this Nov 15, 2018
@y-yagi y-yagi deleted the do_not_suggest_not_exist_command branch November 16, 2018 02:45
bradfitz pushed a commit that referenced this pull request Nov 21, 2018
CL 129682 removed go mod fix but unfortunately
we hadn't updated the source code hence running
   go mod -fix
would suggest
   go mod fix
which is a nonexistent command.

This change fixes that to instead suggest
   go mod tidy

Change-Id: Ie0d7c90805034e9fe6df24afaa15340c44d4f426
GitHub-Last-Rev: 5ae1340
GitHub-Pull-Request: #28402
Reviewed-on: https://go-review.googlesource.com/c/144838
Reviewed-by: Emmanuel Odeke <[email protected]>
Run-TryBot: Emmanuel Odeke <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants