-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: correctly suggest tidy instead of nonexistent fix for -fix #28402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: eab1e55) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/144838 to see it. Tip: You can toggle comments from me using the |
Message from Emmanuel Odeke: Patch Set 1: (2 comments) Thanks for working on this Yuji! Just in case you might not have seen, please make your commit message Please don’t reply on this GitHub thread. Visit golang.org/cl/144838. |
CL 129682 removed go mod fix but unfortunately we hadn't updated the source code hence running go mod -fix would suggest go mod fix which is a nonexistent command. This change fixes that to instead suggest go mod tidy
eab1e55
to
5ae1340
Compare
This PR (HEAD: 5ae1340) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/144838 to see it. Tip: You can toggle comments from me using the |
Message from Yuji Yaginuma: Patch Set 2: Thanks for your review! I updated fix and commit message. Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/144838. |
Message from Emmanuel Odeke: Patch Set 2:
Thanks Yuji. I don't know if you saw my message in https://go-review.googlesource.com/c/go/+/144838/2#message-ca45c6b738a0aad141a4d1f38fcfd9670aba2733 Please don’t reply on this GitHub thread. Visit golang.org/cl/144838. |
Message from Emmanuel Odeke: Patch Set 4: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/144838. |
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=e8f7e221 Please don’t reply on this GitHub thread. Visit golang.org/cl/144838. |
Message from Emmanuel Odeke: Patch Set 4:
Yuji, never mind, I made the edit on Github itself :) Please don’t reply on this GitHub thread. Visit golang.org/cl/144838. |
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/144838. |
CL 129682 removed go mod fix but unfortunately we hadn't updated the source code hence running go mod -fix would suggest go mod fix which is a nonexistent command. This change fixes that to instead suggest go mod tidy Change-Id: Ie0d7c90805034e9fe6df24afaa15340c44d4f426 GitHub-Last-Rev: 5ae1340 GitHub-Pull-Request: #28402 Reviewed-on: https://go-review.googlesource.com/c/144838 Reviewed-by: Emmanuel Odeke <[email protected]> Run-TryBot: Emmanuel Odeke <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
This PR is being closed because golang.org/cl/144838 has been merged. |
CL 129682 removed go mod fix but unfortunately we hadn't updated the source code hence running go mod -fix would suggest go mod fix which is a nonexistent command. This change fixes that to instead suggest go mod tidy Change-Id: Ie0d7c90805034e9fe6df24afaa15340c44d4f426 GitHub-Last-Rev: 5ae1340 GitHub-Pull-Request: #28402 Reviewed-on: https://go-review.googlesource.com/c/144838 Reviewed-by: Emmanuel Odeke <[email protected]> Run-TryBot: Emmanuel Odeke <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
CL 129682 removed go mod fix but unfortunately
we hadn't updated the source code hence running
go mod -fix
would suggest
go mod fix
which is a nonexistent command.
This change fixes that to instead suggest
go mod tidy