-
Notifications
You must be signed in to change notification settings - Fork 18k
math: add architecture independent maxint and maxuint #28537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
This PR (HEAD: b859c07) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/146777 to see it. Tip: You can toggle comments from me using the |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/146777. |
Message from Gerrit User 5065: Patch Set 1: Code-Review-2 Temporary -2 until there's an approved API proposal GitHub issue for this. (We don't add new API just by sending code.) Please don’t reply on this GitHub thread. Visit golang.org/cl/146777. |
53bd915
to
6139019
Compare
4a7ed1f
to
0f992b9
Compare
Message from Akhil Indurti: Patch Set 1: (6 comments) Thanks for sending in this change André! Please take a look at the Editing a commit message for a change sent through GitHub PRs Ping @bradfitz to remove -2, since the proposal has been accepted. Best, Please don’t reply on this GitHub thread. Visit golang.org/cl/146777. |
Implemented architecture independent
MaxInt
,MaxUint
,MinInt
andMinUint
constants for math package.