Skip to content

reflect: add comment for String method of Kind struct - #28818

Closed
cn0047 wants to merge 2 commits into
golang:masterfrom
cn0047:dev-Kovpak-reflect
Closed

reflect: add comment for String method of Kind struct#28818
cn0047 wants to merge 2 commits into
golang:masterfrom
cn0047:dev-Kovpak-reflect

Conversation

@cn0047

@cn0047 cn0047 commented Nov 15, 2018

Copy link
Copy Markdown
Contributor

On reflect documentation page only this function
doesn't have description, this commit add simple description.

@cn0047
reflect: Add comment for String method of Kind struct
0055708 
On reflect documentation page only this function
doesn't have description, this commit add simple description.
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 15, 2018
@gopherbot

gopherbot commented Nov 15, 2018

Copy link
Copy Markdown
Contributor

This PR (HEAD: 0055708) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/149721 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

gopherbot commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/149721.
After addressing review feedback, remember to publish your drafts!

@cn0047
reflect: add comment for String method of Kind struct
1553b83 
On reflect documentation page only this function
doesn't have description, this commit add simple description.
@gopherbot

gopherbot commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

This PR (HEAD: 1553b83) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/149721 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

gopherbot commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

To change the commit message, change the title of the GitHub pull request. See https://github.com/golang/go/wiki/GerritBot . Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/149721.
After addressing review feedback, remember to publish your drafts!

@cn0047 cn0047 changed the title reflect: Add comment for String method of Kind struct reflect: add comment for String method of Kind struct Nov 16, 2018
@gopherbot

gopherbot commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

Message from Vladimir Kovpak:

Patch Set 2:

Patch Set 2:

To change the commit message, change the title of the GitHub pull request. See https://github.com/golang/go/wiki/GerritBot . Thanks.

done

Please don’t reply on this GitHub thread. Visit golang.org/cl/149721.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 16, 2018
@cn0047 @ianlancetaylor
reflect: add comment for String method of Kind struct
722ff6b 
On reflect documentation page only this function
doesn't have description, this commit add simple description.

Change-Id: Idcda89ddd1f6fdd1938c4030e89ebdc186255ce6
GitHub-Last-Rev: 1553b83
GitHub-Pull-Request: #28818
Reviewed-on: https://go-review.googlesource.com/c/149721
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot

gopherbot commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Code-Review+2

Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/149721.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

This PR is being closed because golang.org/cl/149721 has been merged.

@gopherbot gopherbot closed this Nov 16, 2018
bradfitz pushed a commit that referenced this pull request Nov 21, 2018
@cn0047 @ianlancetaylor
reflect: add comment for String method of Kind struct
9ffd5f3 
On reflect documentation page only this function
doesn't have description, this commit add simple description.

Change-Id: Idcda89ddd1f6fdd1938c4030e89ebdc186255ce6
GitHub-Last-Rev: 1553b83
GitHub-Pull-Request: #28818
Reviewed-on: https://go-review.googlesource.com/c/149721
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cn0047 @gopherbot @googlebot