Skip to content

regexp: use backquotes for all regular expression examples - #28879

Closed
cn0047 wants to merge 8 commits into
golang:masterfrom
cn0047:dev-Kovpak-regexp
Closed

regexp: use backquotes for all regular expression examples#28879
cn0047 wants to merge 8 commits into
golang:masterfrom
cn0047:dev-Kovpak-regexp

Conversation

@cn0047

@cn0047 cn0047 commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

This commit performs replace double quote to backquote,
so now all examples looks consistent.

@cn0047
reflect: Add comment for String method of Kind struct
0055708 
On reflect documentation page only this function
doesn't have description, this commit add simple description.
@cn0047
Revert "reflect: Add comment for String method of Kind struct"
93694d7 
This reverts commit 0055708.
@cn0047
regexp: add matching and finding examples
66205b2 
This commit adds examples for Match, Find,
FindAllSubmatch, FindSubmatch and Match functions.
@cn0047
regexp: add matching and finding examples
57239eb 
This commit adds examples for Match, Find,
FindAllSubmatch, FindSubmatch and Match functions.
@cn0047
regexp: add matching and finding examples
33f34b7 
This commit adds examples for Match, Find,
FindAllSubmatch, FindSubmatch and Match functions.
@cn0047
Merge branch 'master' of https://github.com/golang/go
dd998ff
@cn0047
Merge branch 'master' into dev-Kovpak-regexp
058ecd7
@cn0047
regexp: use backquotes for all regular expression examples
e3e636c 
This commit performs replace double quote to backquote,
so now all examples looks consistent.
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 20, 2018
@gopherbot

gopherbot commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

This PR (HEAD: e3e636c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/150397 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

gopherbot commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Message from Rob Pike:

Patch Set 1: Run-TryBot+1 Code-Review+2

Thank you.

Please don’t reply on this GitHub thread. Visit golang.org/cl/150397.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e979cb7a

Please don’t reply on this GitHub thread. Visit golang.org/cl/150397.
After addressing review feedback, remember to publish your drafts!

@gopherbot

gopherbot commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/150397.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 20, 2018
@cn0047 @robpike
regexp: use backquotes for all regular expression examples
bbd1771 
This commit performs replace double quote to backquote,
so now all examples looks consistent.

Change-Id: I8cf760ce1bdeff9619a88e531161b9516385241b
GitHub-Last-Rev: e3e636c
GitHub-Pull-Request: #28879
Reviewed-on: https://go-review.googlesource.com/c/150397
Reviewed-by: Rob Pike <r@golang.org>
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

gopherbot commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

This PR is being closed because golang.org/cl/150397 has been merged.

@gopherbot gopherbot closed this Nov 20, 2018
bradfitz pushed a commit that referenced this pull request Nov 21, 2018
@cn0047 @robpike
regexp: use backquotes for all regular expression examples
55c55dd 
This commit performs replace double quote to backquote,
so now all examples looks consistent.

Change-Id: I8cf760ce1bdeff9619a88e531161b9516385241b
GitHub-Last-Rev: e3e636c
GitHub-Pull-Request: #28879
Reviewed-on: https://go-review.googlesource.com/c/150397
Reviewed-by: Rob Pike <r@golang.org>
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cn0047 @gopherbot @googlebot