-
Notifications
You must be signed in to change notification settings - Fork 18k
fix root_cgo_darwin omits some trusty intermediate ca certificate #30673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 3845283) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/166219 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 421d7cc) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/166219 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/166219. |
Message from Emmanuel Odeke: Patch Set 2: (1 comment) Thank you for this change Penglei and welcome to the Go project! I have added some suggestions to augment your commit message. Please don’t reply on this GitHub thread. Visit golang.org/cl/166219. |
Message from penglei: Patch Set 2:
OK,I will follow up on this matter in the near future. Please don’t reply on this GitHub thread. Visit golang.org/cl/166219. |
Message from Filippo Valsorda: Patch Set 2: I implemented a more conservative fix at https://go-review.googlesource.com/c/go/+/178539, could you test that? Thank you! Please don’t reply on this GitHub thread. Visit golang.org/cl/166219. |
Message from penglei: Patch Set 2:
I tested it. It works very well. I think this PR should be closed. Please don’t reply on this GitHub thread. Visit golang.org/cl/166219. |
This PR is being closed because golang.org/cl/166219 has been abandoned. Superseded by https://go-review.googlesource.com/c/go/+/178539 |
root_cgo_darwin omit intermediate ca certificate if the cert has empty policy settings or an unspecified trust type settings.
Verify the cert instead of ignore it simply. The verification is implemented by calling the security framework interface.
Fixes #30672