Skip to content

net: add KeepAlive field to ListenConfig #31242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

net: add KeepAlive field to ListenConfig #31242

wants to merge 1 commit into from

Conversation

costela
Copy link
Contributor

@costela costela commented Apr 3, 2019

This commit adds a KeepAlive field to ListenConfig and uses it
analogously to Dialer.KeepAlive to set TCP KeepAlives per default on
Accept()

Fixes #23378

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 3, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 1a7e05e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/170678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@costela costela mentioned this pull request Apr 3, 2019
Closed
@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

RELNOTE=yes

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1 Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a451864e

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on openbsd-amd64-64:
See https://storage.googleapis.com/go-build-log/a451864e/openbsd-amd64-64_da065be7.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

19 of 19 TryBots failed:
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/a451864e/openbsd-amd64-64_da065be7.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/a451864e/freebsd-amd64-12_0_af63d54c.log
Failed on nacl-amd64p32: https://storage.googleapis.com/go-build-log/a451864e/nacl-amd64p32_d8376913.log
Failed on nacl-386: https://storage.googleapis.com/go-build-log/a451864e/nacl-386_2f11d094.log
Failed on misc-compile: https://storage.googleapis.com/go-build-log/a451864e/misc-compile_fe039368.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/a451864e/linux-amd64_54729983.log
Failed on misc-compile-ppc: https://storage.googleapis.com/go-build-log/a451864e/misc-compile-ppc_e1f9aa74.log
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/a451864e/misc-vet-vetall_f34f2e7d.log
Failed on misc-compile-freebsd: https://storage.googleapis.com/go-build-log/a451864e/misc-compile-freebsd_dc987cdb.log
Failed on misc-compile-nacl: https://storage.googleapis.com/go-build-log/a451864e/misc-compile-nacl_4b0e863e.log
Failed on misc-compile-netbsd: https://storage.googleapis.com/go-build-log/a451864e/misc-compile-netbsd_568bb1e9.log
Failed on misc-compile-openbsd: https://storage.googleapis.com/go-build-log/a451864e/misc-compile-openbsd_c876bc51.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/a451864e/linux-amd64-race_c1b8c614.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/a451864e/linux-386_8a49b407.log
Failed on js-wasm: https://storage.googleapis.com/go-build-log/a451864e/js-wasm_f1ada594.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/a451864e/windows-amd64-2016_7063e395.log
Failed on misc-compile-mips: https://storage.googleapis.com/go-build-log/a451864e/misc-compile-mips_c1ef9987.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/a451864e/windows-386-2008_49536938.log
Failed on misc-compile-plan9: https://storage.googleapis.com/go-build-log/a451864e/misc-compile-plan9_04aa3eb0.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

Patch Set 1: TryBot-Result-1

19 of 19 TryBots failed:

Forget to compile it before mailing it out? :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@costela
net: add KeepAlive with default to ListenConfig
e9e035d 
This commit adds a KeepAlive field to ListenConfig and uses it
analogously to Dialer.KeepAlive to set TCP KeepAlives per default on
Accept()
@gopherbot
Copy link
Contributor

This PR (HEAD: e9e035d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/170678 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Leo Antunes:

Patch Set 1:

Patch Set 1:

Patch Set 1: TryBot-Result-1

19 of 19 TryBots failed:

Forget to compile it before mailing it out? :)

Last minute "what could go wrong" refactor. Sorry for the awkward noob noise :/

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Leo Antunes:

Patch Set 2:

(2 comments)

Patch Set 1: Run-TryBot+1 Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e674cc4e

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 4, 2019
@costela @bradfitz
net: add KeepAlive field to ListenConfig
1abf3aa 
This commit adds a KeepAlive field to ListenConfig and uses it
analogously to Dialer.KeepAlive to set TCP KeepAlives per default on
Accept()

Fixes #23378

Change-Id: I57eaf9508c979e7f0e2b8c5dd8e8901f6eb27fd6
GitHub-Last-Rev: e9e035d
GitHub-Pull-Request: #31242
Reviewed-on: https://go-review.googlesource.com/c/go/+/170678
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/170678.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/170678 has been merged.

@gopherbot gopherbot closed this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@costela @gopherbot @googlebot