net: fix resolving local windows machine ptr #32214
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 20e5c66) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/178701 to see it. Tip: You can toggle comments from me using the |
|
Message from Brad Fitzpatrick: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
tdabasinskas
changed the title
|
This PR (HEAD: 5a3666f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/178701 to see it. Tip: You can toggle comments from me using the |
|
Message from Alex Brainman: Patch Set 3: Run-TryBot+1 Code-Review+1 (1 comment) Thank you very much for fixing this. I verified your change fixes new test that you've added. I am not network expert, so leaving for others to confirm and submit your change. Alex Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=b3964a75 Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
This PR (HEAD: 0bab12d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/178701 to see it. Tip: You can toggle comments from me using the |
|
Message from Tomas Dabasinskas: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Alex Brainman: Patch Set 4: Run-TryBot+1 Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=56dcf77d Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Alex Brainman: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
This PR (HEAD: 76cbdb9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/178701 to see it. Tip: You can toggle comments from me using the |
|
Message from Tomas Dabasinskas: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Alex Brainman: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Gobot Gobot: Patch Set 5: TryBots beginning. Status page: https://farmer.golang.org/try?commit=4811898f Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Gobot Gobot: Patch Set 5: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
|
Message from Alex Brainman: Patch Set 5: (1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/178701. |
Fixes #29600 Change-Id: Ie60b5c8f8356dfc16b3ef6d3cee520b9ce6a61aa GitHub-Last-Rev: 76cbdb9 GitHub-Pull-Request: #32214 Reviewed-on: https://go-review.googlesource.com/c/go/+/178701 Run-TryBot: Alex Brainman <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Alex Brainman <[email protected]>
|
This PR is being closed because golang.org/cl/178701 has been merged. |
Fixes golang#29600 Change-Id: Ie60b5c8f8356dfc16b3ef6d3cee520b9ce6a61aa GitHub-Last-Rev: 76cbdb9 GitHub-Pull-Request: golang#32214 Reviewed-on: https://go-review.googlesource.com/c/go/+/178701 Run-TryBot: Alex Brainman <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Alex Brainman <[email protected]>
Fixes golang#29600 Change-Id: Ie60b5c8f8356dfc16b3ef6d3cee520b9ce6a61aa GitHub-Last-Rev: 76cbdb9 GitHub-Pull-Request: golang#32214 Reviewed-on: https://go-review.googlesource.com/c/go/+/178701 Run-TryBot: Alex Brainman <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Alex Brainman <[email protected]>
Fixes #29600