Skip to content

io: make CopyBuffer docs state when buf is not used #32279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

io: make CopyBuffer docs state when buf is not used #32279

wants to merge 4 commits into from

Conversation

sandyskies
Copy link
Contributor

@sandyskies sandyskies commented May 28, 2019 •
edited
Loading

Document that if either src implements the WriteTo interface
or if dst implements the ReaderFrom interface, then
buf will not be used.

Fixes #32276

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 28, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: e129ac2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/179137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@sandyskies sandyskies mentioned this pull request May 29, 2019
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: 5244676) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/179137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@sandyskies sandyskies force-pushed the comment-remend-io-CopyBuffer branch from 5244676 to 8928a5e Compare May 30, 2019 09:59
@gopherbot
Copy link
Contributor

This PR (HEAD: 8928a5e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/179137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 3:

(2 comments)

Thank you for this change ChenMingjie! I've added some suggestions for your CL, please take a look.

Please don’t reply on this GitHub thread. Visit golang.org/cl/179137.
After addressing review feedback, remember to publish your drafts!

@sandyskies sandyskies changed the title io:add comment for io.CopyBuffer for more precise io: make CopyBuffer docs state when buf is not used Oct 20, 2019
@sandyskies
io: make CopyBuffer docs state when buf is not used
1b541b4 
Document that if either src implements the WriteTo interface
or if dst implements the ReaderFrom interface, then
buf will not be used.

Fixes golang#32276
@gopherbot
Copy link
Contributor

This PR (HEAD: 1b541b4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/179137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Sandyskies Chan:

Patch Set 6:

Patch Set 3:

(2 comments)

Thank you for this change ChenMingjie! I've added some suggestions for your CL, please take a look.

Already updated as u require, Please look at it again thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/179137.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/179137.
After addressing review feedback, remember to publish your drafts!

@sandyskies
io: make CopyBuffer docs state when buf is not used
750e7e8 
Document that if either src implements the WriteTo interface
or if dst implements the ReaderFrom interface, then
buf will not be used.

Fixes golang#32276
@gopherbot
Copy link
Contributor

This PR (HEAD: 750e7e8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/179137 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot pushed a commit that referenced this pull request Oct 21, 2019
@sandyskies @odeke-em
io: make CopyBuffer docs state when buf is not used
03978a9 
Document that if either src implements the WriteTo interface
or if dst implements the ReaderFrom interface, then
buf will not be used.

Fixes #32276

Change-Id: Id0a69c90e255e694e7ec9f79ffe4d8391441e59e
GitHub-Last-Rev: 750e7e8
GitHub-Pull-Request: #32279
Reviewed-on: https://go-review.googlesource.com/c/go/+/179137
Reviewed-by: Emmanuel Odeke <[email protected]>
@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 8: Code-Review+2

Thank you ChenMingjie for the change and Ian for the review too! LGTM.

Please don’t reply on this GitHub thread. Visit golang.org/cl/179137.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/179137 has been merged.

@gopherbot gopherbot closed this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

io: CopyBuffer should document when buf is not used
3 participants
@sandyskies @gopherbot @googlebot