-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: package modules into mod format for upload #34104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: c80eef6) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/193557 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/193557. |
This PR (HEAD: 82637ab) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/193557 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: f69f202) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/193557 to see it. Tip: You can toggle comments from me using the |
Message from Bryan C. Mills: Patch Set 3: We should discuss the API on the linked issue before we get into too much detail on the implementation. (For example, it's not obvious to me that this should be built in to the Please don’t reply on this GitHub thread. Visit golang.org/cl/193557. |
Message from Mark Dodgson: Patch Set 3:
How should I progress with this? (apologies never contributed in this way before) Please don’t reply on this GitHub thread. Visit golang.org/cl/193557. |
53bd915
to
6139019
Compare
Message from Bryan C. Mills: Patch Set 3:
Not sure. I think Jay is planning to look at this for the Please don’t reply on this GitHub thread. Visit golang.org/cl/193557. |
Message from Jay Conrod: Patch Set 3:
I'm working on a CL that will add a package golang.org/x/mod/archive with the functions: func CreateFromDir(w io.Writer, m module.Version, dir string) error Once that's merged and we've verified it produces the same zips as the go command currently does, we can delete that functionality from the go command and use the x/mod packages. It will be trivial to write "pack" and "push" tools around that. I may include a "pack" tool, but I expect that the "push" workflow will need to be customized a bit for every server, so it's probably best if people write their own tools for that. Please don’t reply on this GitHub thread. Visit golang.org/cl/193557. |
4a7ed1f
to
0f992b9
Compare
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/193557. |
Currently, there is no mechanism to package the content of a module project into a zip that is compatible with the go mod system
This PR adds a
go mod pack
command that does just that and ago mod push
to then upload the generated zip to a hosted repositoryFixes #33312