-
Notifications
You must be signed in to change notification settings - Fork 18.1k
crypto/x509: this change modifies C.CopyPEMRoots to static function #36491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 6a07f25) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/214298 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/214298. |
Message from Ian Lance Taylor: Patch Set 1: Run-TryBot+1 TRY=darwin-amd64,darwin-arm64 Please don’t reply on this GitHub thread. Visit golang.org/cl/214298. |
Message from Gobot Gobot: Patch Set 1: SlowBots beginning. Status page: https://farmer.golang.org/try?commit=f1ded899 Please don’t reply on this GitHub thread. Visit golang.org/cl/214298. |
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 SlowBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/214298. |
Change-Id: Ic7997d1f747152afec78e8e439770166029f34ec GitHub-Last-Rev: 6a07f25 GitHub-Pull-Request: #36491 Reviewed-on: https://go-review.googlesource.com/c/go/+/214298 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Message from Ian Lance Taylor: Patch Set 1: Code-Review+2 Thanks. Committing to 1.14 because this will affect Darwin programs that use cgo. We should not intrude on the C namespace. Please don’t reply on this GitHub thread. Visit golang.org/cl/214298. |
This PR is being closed because golang.org/cl/214298 has been merged. |
Change-Id: Ic7997d1f747152afec78e8e439770166029f34ec GitHub-Last-Rev: 6a07f25056c960dc8684cd6eac22cd3405a936c8 GitHub-Pull-Request: golang/go#36491 Reviewed-on: https://go-review.googlesource.com/c/go/+/214298 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
No description provided.