Skip to content

path/filepath: try GetFinalPathNameByHandle with VOLUME_NAME_GUID #40095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ericwj
Copy link

@ericwj ericwj commented Jul 7, 2020

EvalSymLinks calls into normaliseLinkPath, which will now also use GetFinalPathNameByHandle with VOLUME_NAME_GUID to resolve reparse points to paths.

Fixes #39786

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 7, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 3cc44f4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/241278 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/241278.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Brainman:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/241278.
After addressing review feedback, remember to publish your drafts!

ericwj added 2 commits July 12, 2020 18:15
This documentation change is the best solution for EvalSymLinks short of deleting this API altogether.

EvalSymLinks is not suitable on any operating system because it unconditionally undoes indirections without being aware of the problems that these indirections solve.

This is a violation of the software engineering principle which states:

> Any problem in software can be solved by adding another layer of indirection.
path/filepath: fix EvalSymLink documentation
@gopherbot
Copy link
Contributor

This PR (HEAD: 8dd4b4d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/241278 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/241278.
After addressing review feedback, remember to publish your drafts!

@ericwj ericwj closed this Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
3 participants