-
Notifications
You must be signed in to change notification settings - Fork 18k
path/filepath: try GetFinalPathNameByHandle with VOLUME_NAME_GUID #40095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 3cc44f4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/241278 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/241278. |
Message from Alex Brainman: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241278. |
This documentation change is the best solution for EvalSymLinks short of deleting this API altogether. EvalSymLinks is not suitable on any operating system because it unconditionally undoes indirections without being aware of the problems that these indirections solve. This is a violation of the software engineering principle which states: > Any problem in software can be solved by adding another layer of indirection.
path/filepath: fix EvalSymLink documentation
This PR (HEAD: 8dd4b4d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/241278 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/241278. |
EvalSymLinks calls into normaliseLinkPath, which will now also use GetFinalPathNameByHandle with VOLUME_NAME_GUID to resolve reparse points to paths.
Fixes #39786