time: support fractional timezone minutes in MarshalBinary #40293

howjmay · 2020-07-19T14:20:48Z

If the time is in 'LMT' and has fractional minute, then
MarshalBinary() and UnmarshalBinary() will encode/decode the time
in timeBinaryVersionV2 in which the fractional minute is at
bit 15 and 16, and presented in seconds.

Fixes #39616

gopherbot · 2020-07-19T14:23:41Z

This PR (HEAD: 5259b3b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-07-20T17:09:10Z

This PR (HEAD: c236273) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

howjmay · 2020-08-08T18:09:26Z

Hi @rsc is there anything that I should add or fix in this pr?

gopherbot · 2021-07-08T19:54:12Z

Message from Hau Yang:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T03:36:13Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T03:57:51Z

Message from Hau Yang:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-21T09:08:19Z

Message from Hau Yang:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-21T16:37:22Z

Message from Ian Lance Taylor:

Patch Set 2:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-21T16:37:23Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-22T09:33:58Z

This PR (HEAD: e635355) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-22T09:36:29Z

This PR (HEAD: 560fe45) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-22T09:38:59Z

This PR (HEAD: 3ffb959) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-22T09:41:25Z

Message from Hau Yang:

Patch Set 2:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-22T20:38:49Z

Message from Ian Lance Taylor:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-23T20:04:34Z

This PR (HEAD: 799caf9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-23T20:07:30Z

This PR (HEAD: ef96010) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-23T20:10:25Z

This PR (HEAD: fc29404) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-23T20:16:46Z

This PR (HEAD: e55c117) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-23T20:19:23Z

Message from Hau Yang:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-15T00:40:31Z

Message from Ian Lance Taylor:

Patch Set 9:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T14:36:51Z

This PR (HEAD: 280628f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-09-16T14:42:16Z

Message from Hau Yang:

Patch Set 10:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T17:50:56Z

Message from Ian Lance Taylor:

Patch Set 10:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

If the time is in 'LMT' and has fractional minute, then `MarshalBinary()` and `UnmarshalBinary()` will encode/decode the time in `timeBinaryVersionV2` in which the fractional minute is at bit 15 and 16, and presented in seconds. Fixes golang#39616

gopherbot · 2021-09-16T18:22:13Z

This PR (HEAD: 455d7a2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/243402 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-09-16T18:25:31Z

Message from Hau Yang:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T18:28:17Z

Message from Ian Lance Taylor:

Patch Set 11: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T18:33:50Z

Message from Go Bot:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T18:33:51Z

Message from Go Bot:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:09:03Z

Message from Go Bot:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:09:04Z

Message from Go Bot:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:09:05Z

Message from Go Bot:

Patch Set 11: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:09:06Z

Message from Ian Lance Taylor:

Patch Set 12: Patch Set 11 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:09:06Z

Message from Ian Lance Taylor:

Patch Set 12: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:09:07Z

Message from Go Bot:

Patch Set 12:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:09:08Z

Message from Go Bot:

Patch Set 12: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:09:08Z

Message from Ian Lance Taylor:

Patch Set 12: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-16T19:28:44Z

Message from Hau Yang:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-09-17T23:09:32Z

Message from Carlos Amedee:

Patch Set 12: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/243402.
After addressing review feedback, remember to publish your drafts!

If the time is in 'LMT' and has fractional minute, then `MarshalBinary()` and `UnmarshalBinary()` will encode/decode the time in `timeBinaryVersionV2` in which the fractional minute is at bit 15 and 16, and presented in seconds. Fixes #39616 Change-Id: Ib762fb5fa26f54b1a8377a5dde0b994dd5a1236a GitHub-Last-Rev: 455d7a2 GitHub-Pull-Request: #40293 Reviewed-on: https://go-review.googlesource.com/c/go/+/243402 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Carlos Amedee <[email protected]>

gopherbot · 2021-09-17T23:19:59Z

This PR is being closed because golang.org/cl/243402 has been merged.

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 19, 2020

howjmay force-pushed the fail_MarshalBinary branch from 5259b3b to c236273 Compare July 20, 2020 17:08

howjmay force-pushed the fail_MarshalBinary branch from c236273 to e635355 Compare August 22, 2021 09:32

howjmay changed the title ~~src/time: Support LMT in MarshalBinary, UnmarshalBinary~~ time: support fractional timezone minutes in MarshalBinary Aug 22, 2021

howjmay force-pushed the fail_MarshalBinary branch 2 times, most recently from d40bddf to 560fe45 Compare August 22, 2021 09:36

howjmay force-pushed the fail_MarshalBinary branch from 560fe45 to 3ffb959 Compare August 22, 2021 09:37

howjmay force-pushed the fail_MarshalBinary branch from 3ffb959 to 799caf9 Compare August 23, 2021 20:04

howjmay force-pushed the fail_MarshalBinary branch from 799caf9 to ef96010 Compare August 23, 2021 20:06

howjmay force-pushed the fail_MarshalBinary branch from ef96010 to fc29404 Compare August 23, 2021 20:09

howjmay force-pushed the fail_MarshalBinary branch from fc29404 to e55c117 Compare August 23, 2021 20:15

howjmay force-pushed the fail_MarshalBinary branch from e55c117 to 280628f Compare September 16, 2021 14:34

howjmay force-pushed the fail_MarshalBinary branch from 280628f to 455d7a2 Compare September 16, 2021 18:20

gopherbot closed this Sep 17, 2021

time: support fractional timezone minutes in MarshalBinary #40293

time: support fractional timezone minutes in MarshalBinary #40293

Uh oh!

Conversation

howjmay commented Jul 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 19, 2020

Uh oh!

gopherbot commented Jul 20, 2020

Uh oh!

howjmay commented Aug 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 8, 2021

Uh oh!

gopherbot commented Jul 9, 2021

Uh oh!

gopherbot commented Jul 9, 2021

Uh oh!

gopherbot commented Aug 21, 2021

Uh oh!

gopherbot commented Aug 21, 2021

Uh oh!

gopherbot commented Aug 21, 2021

Uh oh!

gopherbot commented Aug 22, 2021

Uh oh!

gopherbot commented Aug 22, 2021

Uh oh!

gopherbot commented Aug 22, 2021

Uh oh!

gopherbot commented Aug 22, 2021

Uh oh!

gopherbot commented Aug 22, 2021

Uh oh!

gopherbot commented Aug 23, 2021

Uh oh!

gopherbot commented Aug 23, 2021

Uh oh!

gopherbot commented Aug 23, 2021

Uh oh!

gopherbot commented Aug 23, 2021

Uh oh!

gopherbot commented Aug 23, 2021

Uh oh!

gopherbot commented Sep 15, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

gopherbot commented Sep 16, 2021

Uh oh!

howjmay commented Jul 19, 2020 •

edited

Loading

howjmay commented Aug 8, 2020 •

edited

Loading