-
Notifications
You must be signed in to change notification settings - Fork 18k
encoding/asn1: add dynamic length integer support for base 128 integer parsing #40738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 55e7f5b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/248259 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/248259. |
Message from Adam Langley: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/248259. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/248259. |
encoding/asn1 parsed base 128 integers as strictly 32-bit, causing
certificates encoded in 64-bit to fail. This addresses the 64-bit issue
and maintains support for 32-bit platforms.
Fixes #36467