runtime: don't crash if vsyscall and vdso are disabled on x86_64 #41681

avagin · 2020-09-28T17:18:23Z

If vdso is disabled, the goruntime calls gettimeofday from vsyscall,
but if vsyscall is disabled too, all golang binaries crash:

SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0xffffffffff600000} ---
killed by SIGSEGV (core dumped) ++

vsyscall doesn't work as it was designed for a long time due to security
reasons and now vsyscall is a little more expensive than real syscalls:
torvalds/linux@5cec93c216db

This patch reworks the code to call syscalls if the vdso library isn't
available.

gopherbot · 2020-09-28T17:23:58Z

This PR (HEAD: 1764124) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/257982 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-28T17:47:46Z

Message from Michael Pratt:

Patch Set 2: Run-TryBot+1 Code-Review+1 Trust+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T17:47:47Z

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=9681add4

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T17:53:17Z

Message from Gobot Gobot:

Patch Set 2:

Build is still in progress...
This change failed on windows-386-2008:
See https://storage.googleapis.com/go-build-log/9681add4/windows-386-2008_02b833f3.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T17:57:22Z

Message from Gobot Gobot:

Patch Set 2: TryBot-Result-1

1 of 20 TryBots failed:
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/9681add4/windows-386-2008_02b833f3.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T18:29:16Z

This PR (HEAD: d662e13) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/257982 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-28T18:31:18Z

This PR (HEAD: 3ee50a5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/257982 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-28T18:36:51Z

This PR (HEAD: 32a7301) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/257982 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-28T18:40:39Z

Message from Andrei Vagin:

Patch Set 5:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T19:10:22Z

Message from Michael Pratt:

Patch Set 6: Run-TryBot+1 Code-Review+2

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T19:10:23Z

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=f9a55a90

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T19:21:33Z

Message from Gobot Gobot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T19:39:40Z

This PR (HEAD: 098fd23) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/257982 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-28T19:43:55Z

This PR (HEAD: 7846e34) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/257982 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-28T19:47:31Z

Message from Andrei Vagin:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-28T22:48:04Z

Message from Ian Lance Taylor:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

If vdso is disabled, the goruntime calls gettimeofday from vsyscall. But if vsyscall is disabled too, all golang binaries crash: SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0xffffffffff600000} --- killed by SIGSEGV (core dumped) ++ vsyscall doesn't work as it was designed for a long time due to security reasons and now vsyscall is a little more expensive than real syscalls: torvalds/linux@5cec93c216db This patch reworks the code to call syscalls if the vdso library isn't available. Signed-off-by: Andrei Vagin <[email protected]>

gopherbot · 2020-09-29T04:46:01Z

This PR (HEAD: 1d133cd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/257982 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-09-29T04:52:49Z

Message from Andrei Vagin:

Patch Set 9:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-29T06:14:09Z

Message from Tobias Klauser:

Patch Set 9: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-29T06:14:10Z

Message from Gobot Gobot:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3f69a3dc

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-29T06:25:24Z

Message from Gobot Gobot:

Patch Set 9: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/257982.
After addressing review feedback, remember to publish your drafts!

If vdso is disabled, the goruntime calls gettimeofday from vsyscall, but if vsyscall is disabled too, all golang binaries crash: SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0xffffffffff600000} --- killed by SIGSEGV (core dumped) ++ vsyscall doesn't work as it was designed for a long time due to security reasons and now vsyscall is a little more expensive than real syscalls: torvalds/linux@5cec93c216db This patch reworks the code to call syscalls if the vdso library isn't available. Change-Id: I16cbf3f49871bea91e26af1f49aa0ae2fbd3a01d GitHub-Last-Rev: 1d133cd GitHub-Pull-Request: #41681 Reviewed-on: https://go-review.googlesource.com/c/go/+/257982 Run-TryBot: Tobias Klauser <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Michael Pratt <[email protected]> Trust: Michael Pratt <[email protected]>

gopherbot · 2020-09-30T05:42:21Z

This PR is being closed because golang.org/cl/257982 has been merged.

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 28, 2020

avagin force-pushed the vdso branch from 1764124 to d662e13 Compare September 28, 2020 18:28

avagin force-pushed the vdso branch from d662e13 to 3ee50a5 Compare September 28, 2020 18:30

avagin force-pushed the vdso branch from 3ee50a5 to 32a7301 Compare September 28, 2020 18:35

avagin force-pushed the vdso branch from 32a7301 to 098fd23 Compare September 28, 2020 19:39

avagin changed the title ~~x86: Don't crash if vsyscall and vdso are disabled~~ runtime: Don't crash if vsyscall and vdso are disabled on x86_64 Sep 28, 2020

avagin force-pushed the vdso branch from 098fd23 to 7846e34 Compare September 28, 2020 19:43

avagin force-pushed the vdso branch from 7846e34 to 1d133cd Compare September 29, 2020 04:44

avagin changed the title ~~runtime: Don't crash if vsyscall and vdso are disabled on x86_64~~ runtime: don't crash if vsyscall and vdso are disabled on x86_64 Sep 29, 2020

gopherbot closed this Sep 30, 2020

skmp mentioned this pull request Oct 8, 2020

Golang needs VDSO and/or vsyscall FEX-Emu/FEX#117

Closed

runtime: don't crash if vsyscall and vdso are disabled on x86_64 #41681

runtime: don't crash if vsyscall and vdso are disabled on x86_64 #41681

Uh oh!

Conversation

avagin commented Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 28, 2020

Uh oh!

gopherbot commented Sep 29, 2020

Uh oh!

gopherbot commented Sep 29, 2020

Uh oh!

gopherbot commented Sep 29, 2020

Uh oh!

gopherbot commented Sep 29, 2020

Uh oh!

gopherbot commented Sep 29, 2020

Uh oh!

gopherbot commented Sep 30, 2020

Uh oh!

Uh oh!

avagin commented Sep 28, 2020 •

edited

Loading