Skip to content

os: call f.Close before t.Fatal to avoid vet unreachable code warnings #41900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

os: call f.Close before t.Fatal to avoid vet unreachable code warnings #41900

wants to merge 1 commit into from

Conversation

geektutu
Copy link
Contributor

@geektutu geektutu commented Oct 10, 2020 •
edited
Loading

No description provided.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 10, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 303e524) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261217 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/261217.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261217.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=548d6e89

Please don’t reply on this GitHub thread. Visit golang.org/cl/261217.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/261217.
After addressing review feedback, remember to publish your drafts!

@geektutu geektutu changed the title os: call f.Close() before t.Fatal to avoid f.Close() unreachable os: call File.Close before t.Fatal to avoid vet unreachable code warnings Oct 12, 2020
@odeke-em odeke-em changed the title os: call File.Close before t.Fatal to avoid vet unreachable code warnings os: call f.Close before t.Fatal to avoid vet unreachable code warnings Oct 12, 2020
@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 4: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261217.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ad81c94d

Please don’t reply on this GitHub thread. Visit golang.org/cl/261217.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/261217.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Oct 12, 2020
@geektutu @tklauser
os: call f.Close before t.Fatal to avoid vet unreachable code warnings
e92ce92 
Change-Id: Ic3f756ecf9b4fad8fb8c259e7dad6df894863b0e
GitHub-Last-Rev: 303e524
GitHub-Pull-Request: #41900
Reviewed-on: https://go-review.googlesource.com/c/go/+/261217
Run-TryBot: Emmanuel Odeke <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Tobias Klauser <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
Trust: Emmanuel Odeke <[email protected]>
@gopherbot
Copy link
Contributor

Message from Tobias Klauser:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/261217.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/261217 has been merged.

@gopherbot gopherbot closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geektutu @gopherbot