-
Notifications
You must be signed in to change notification settings - Fork 18k
syscall: expose bInheritHandles of CreateProcess #41957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Certain use cases require this parameter to be false. This includes spawning a child process in a different windows session than session 0. Docs regarding the behavior of this parameter to CreateProcess: https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: 00acb42) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/261917 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Ian Lance Taylor: Patch Set 1: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=826e0324 Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
This PR (HEAD: 3ec8799) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/261917 to see it. Tip: You can toggle comments from me using the |
Message from Johan Knutzen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Johan Knutzen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Johan Knutzen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Tobias Klauser: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=19b9a96a Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Gobot Gobot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Tobias Klauser: Patch Set 2: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Go Bot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=826e0324 Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Go Bot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=19b9a96a Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Alex Brainman: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Johan Knutzen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Johan Knutzen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Alex Brainman: Patch Set 2: Code-Review+2 Trust+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
This PR (HEAD: ad8e36d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/261917 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 9f4d126) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/261917 to see it. Tip: You can toggle comments from me using the |
Message from Johan Knutzen: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Ian Lance Taylor: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Ian Lance Taylor: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
This PR (HEAD: f5ee7ab) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/261917 to see it. Tip: You can toggle comments from me using the |
Message from Johan Knutzen: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Ian Lance Taylor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Alex Brainman: Patch Set 5: Code-Review+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Johan Knutzen: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
This PR (HEAD: 584eb13) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/261917 to see it. Tip: You can toggle comments from me using the |
Message from Johan Knutzen: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Tobias Klauser: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Johan Knutzen: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Tobias Klauser: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Johan Knutzen: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Alex Brainman: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Ian Lance Taylor: Patch Set 8: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Go Bot: Patch Set 8: TryBots beginning. Status page: https://farmer.golang.org/try?commit=d37d6f91 Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Message from Go Bot: Patch Set 8: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
Certain use cases require this parameter to be false. This includes spawning a child process in a different windows session than session 0. Docs regarding the behavior of this parameter to CreateProcess: https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa Fixes #42098 Change-Id: If998f57d6f2962824aacbee75e1b508b255ab293 GitHub-Last-Rev: 584eb13 GitHub-Pull-Request: #41957 Reviewed-on: https://go-review.googlesource.com/c/go/+/261917 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Tobias Klauser <[email protected]> Trust: Alex Brainman <[email protected]>
Message from Ian Lance Taylor: Patch Set 8: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/261917. |
This PR is being closed because golang.org/cl/261917 has been merged. |
Certain use cases require this parameter to be false. This includes
spawning a child process in a different windows session than session 0.
Docs regarding the behavior of this parameter to CreateProcess:
https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa
Fixes #42098