net: use the size be sent as the count param of sendfile #45270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

qingyunha wants to merge 1 commit into golang:master from qingyunha:send_file

Contributor

qingyunha commented Mar 28, 2021

if the count param of sendfile larger than the file size to be sent,
the TCP will cause a 200ms delay somehow.

Fixes #41513
Fixes #45256


          net: use the size be sent as the count param of sendfile

f4e5e16

if the count param of sendfile larger than the file size to be sent,
the TCP will cause a 200ms delay somehow.

Fixes golang#41513
Fixes golang#45256

google-cla bot added the cla: yes label

Contributor

gopherbot commented Mar 28, 2021

This PR (HEAD: f4e5e16) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305229 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Mar 28, 2021

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305229.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 28, 2021

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d4973837

Please don’t reply on this GitHub thread. Visit golang.org/cl/305229.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 28, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/305229.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 30, 2021

Message from 陶青云:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305229.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 30, 2021

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305229.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 30, 2021

Message from 陶青云:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305229.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Mar 30, 2021

This PR is being closed because golang.org/cl/305229 has been abandoned.

Not doing this, unless we get more convincing data.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels