net: reference the correct RFCs and sections for IP.IsPrivate #45500
Conversation
google-cla
bot
added
the
cla: yes
|
ref: https://tools.ietf.org/html/rfc4193#section-8 @odeke-em If you think there is a better commit msg / pull title just tell me :) |
|
This PR (HEAD: 7d4b10c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/309249 to see it. Tip: You can toggle comments from me using the |
|
Message from Emmanuel Odeke: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
Properly cite RFC 1918 Section 3 for ipv4, and RFC 4193 Section 8 for ipv6 comments. Updates 1c9e587 Signed-off-by: 6543 <[email protected]>
6543
force-pushed
the
net/IP.IsPrivate_doc
branch
from
7d4b10c to
b034179
Compare
6543
changed the title
|
This PR (HEAD: b034179) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/309249 to see it. Tip: You can toggle comments from me using the |
|
Message from Emmanuel Odeke: Patch Set 2: Run-TryBot+1 Code-Review+2 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
|
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=7dff2888 Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
|
Message from Go Bot: Patch Set 2: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
|
Message from Go Bot: Patch Set 2: TryBot-Result-1 1 of 23 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
|
Message from Tobias Klauser: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
|
Message from 6543: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
|
Message from Tobias Klauser: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
|
Message from Tobias Klauser: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
|
Message from Tobias Klauser: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/309249. |
Properly cite RFC 1918 Section 3 for ipv4, and RFC 4193 Section 8 for ipv6 comments. Updates #29146 Change-Id: I8a2df0d7bef50444294bb3301fe09fb09f21ffaf GitHub-Last-Rev: b034179 GitHub-Pull-Request: #45500 Reviewed-on: https://go-review.googlesource.com/c/go/+/309249 Reviewed-by: Emmanuel Odeke <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> Run-TryBot: Emmanuel Odeke <[email protected]>
|
This PR is being closed because golang.org/cl/309249 has been merged. |
Properly cite RFC 1918 Section 3 for ipv4,
and RFC 4193 Section 8 for ipv6 comments.
Updates #29146