cmd/go: use exit code from compiled test binary on error #45509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
This PR (HEAD: 6a4701e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/309250 to see it. Tip: You can toggle comments from me using the |
|
Message from Bryan C. Mills: Patch Set 2: Code-Review-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/309250. |
|
Message from Bryan C. Mills: Patch Set 2: Code-Review-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/309250. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45508
Use the exit code from the compiled test binary, when the exec
exits with an error. This allows programs which run 'go test -json'
to determine if all the tests were run, or if a panic caused the run
to exit before running all tests.