-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: populate module info even if an error occurs in loading package #45777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 1221340) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/313549 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/313549. |
Message from Bryan C. Mills: Patch Set 2: Run-TryBot+1 Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/313549. |
Message from Go Bot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/313549. |
Message from Go Bot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/313549. |
Message from Bryan C. Mills: Patch Set 2: -Code-Review (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/313549. |
Message from Go Bot: Patch Set 2: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/313549. |
This PR (HEAD: f4d6435) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/313549 to see it. Tip: You can toggle comments from me using the |
The existing implementation ignores module info if there is any error loading the package. Fixes golang#44287
This PR (HEAD: 28e9bf8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/313549 to see it. Tip: You can toggle comments from me using the |
Message from unbyte: Patch Set 5: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/313549. |
/comments off |
The existing implementation ignores module info if there is any error loading the package. Fixes #44287 Change-Id: I24142e4c7256517292fc654e29d759871b80bc09 GitHub-Last-Rev: 28e9bf8 GitHub-Pull-Request: #45777 Reviewed-on: https://go-review.googlesource.com/c/go/+/313549 Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Michael Matloob <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Go Bot <[email protected]> Trust: Michael Matloob <[email protected]>
The existing implementation ignores module info if there is any error loading the package.
Fixes #44287