Skip to content

cmd/go: populate module info even if an error occurs in loading package #45777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

unbyte
Copy link
Contributor

@unbyte unbyte commented Apr 26, 2021

The existing implementation ignores module info if there is any error loading the package.

Fixes #44287

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 26, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 1221340) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/313549 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/313549.
After addressing review feedback, remember to publish your drafts!

@unbyte unbyte changed the title cmd/go: populate module info even certain error occurs in go list cmd/go: populate module info even certain error occurs in loading package Apr 27, 2021
@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2: Run-TryBot+1 Code-Review+2

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/313549.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/313549.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/313549.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2: -Code-Review

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/313549.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2: TryBot-Result-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/313549.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: f4d6435) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/313549 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@unbyte unbyte changed the title cmd/go: populate module info even certain error occurs in loading package cmd/go: populate module info even if an error occurs in loading package Apr 28, 2021
The existing implementation ignores module info if there is any error loading the package.

Fixes golang#44287
@gopherbot
Copy link
Contributor

This PR (HEAD: 28e9bf8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/313549 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from unbyte:

Patch Set 5:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/313549.
After addressing review feedback, remember to publish your drafts!

@unbyte
Copy link
Contributor Author

unbyte commented Apr 28, 2021

/comments off

@gopherbot gopherbot closed this Apr 28, 2021
gopherbot pushed a commit that referenced this pull request Apr 28, 2021
The existing implementation ignores module info if there is any error loading the package.

Fixes #44287

Change-Id: I24142e4c7256517292fc654e29d759871b80bc09
GitHub-Last-Rev: 28e9bf8
GitHub-Pull-Request: #45777
Reviewed-on: https://go-review.googlesource.com/c/go/+/313549
Reviewed-by: Bryan C. Mills <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Trust: Michael Matloob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/go: no Module information in list -e output after any error loading package
2 participants