-
Notifications
You must be signed in to change notification settings - Fork 18k
[dev.fuzz] internal/fuzz: avoid corruption of minimized crashers #47591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: ee9b8cb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/340630 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
Message from Katie Hockman: Patch Set 1: Run-TryBot+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
Message from Go Bot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
Message from Go Bot: Patch Set 1: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
Message from Katie Hockman: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
This PR (HEAD: bc63663) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/340630 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 1f9e8dd) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/340630 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 707e923) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/340630 to see it. Tip: You can toggle comments from me using the |
Message from Katie Hockman: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
In workerServer.minimizeInput, the callback "tryMinimize" can receive byte slices which will be modified after the callback returns. Similarly to the case where the "candidate" is a string, make a copy of the byte slice. Fixes golang#47587
707e923
to
d7edb89
Compare
This PR (HEAD: d7edb89) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/340630 to see it. Tip: You can toggle comments from me using the |
Message from Steven Johnstone: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
Message from Steven Johnstone: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
Message from Steven Johnstone: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
Message from Steven Johnstone: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
Message from Katie Hockman: Patch Set 5: Code-Review-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/340630. |
In workerServer.minimizeInput, the callback "tryMinimize" can receive
byte slices which will be modified after the callback returns. Similarly
to the case where the "candidate" is a string, make a copy of the byte
slice.
Fixes #47587