archive/zip: load file data descriptor on demand #48755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read file data descriptor only when the file is open. Previously, during zip.Reader.init, each new file had its data descriptor read during the file discovery loop. This caused extra reads for those who want just to list the files. Fixes golang#48374
Reuse previous body offset read in file data descriptor.
google-cla
bot
added
the
cla: yes
|
This PR (HEAD: 43a498d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/353716 to see it. Tip: You can toggle comments from me using the |
|
Looks like this was already fixed by https://go-review.googlesource.com/c/go/+/357489 around the same time. Please don't feel discouraged that your change didn't get reviewed and merged - with such a large open source project, duplicated work happens at times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read file data descriptor only when the file is open.
Previously, during zip.Reader.init, each new file had its data descriptor
read during the file discovery loop. This caused extra reads for those who
want just to list the files.
Fixes #48374