benchmark timeout when benchtime set too long #49950
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When benchmark function execute time is very short, set benchtime=5s / 10s / 20s is ok.
But set benchtime=120s will execute time out.
benchtime short
The
B.n
maybe 1 , 100 , 10000, 1000000, 100000000, 100000000 and exist.benchtime long
But set benchtime=120s,
n = goalns * prevIters / prevns
may be overflow(< 0) int64, and theB.n
maybe 1, 100, 10000, 1000000, 100000000, 100000001, 100000002 .... and timeout.